The default bug view has changed. See this FAQ.

Support appearance attribute for select1

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
8 months ago

People

(Reporter: Allan Beaufour, Assigned: surkov)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

2.20 KB, application/xhtml+xml
Details
4.37 KB, application/xhtml+xml
Details
9.13 KB, patch
Doron Rosenberg (IBM)
: review+
aaronr
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
We need to support appearance "full", "compact", and "minimal". If we want to
look like the examples in the spec. that means we still need "full" and "compact".

Comment 1

12 years ago
afaik <select> will support full and compact. Perhaps that implementation can be
used also with <select1>. Though I'm not sure what the UI should look like
when selection="open" and appearance is either full or compact.
Depends on: 300801

Comment 2

12 years ago
Created attachment 204749 [details]
testcase

I suggest that we handle select1 with @appearance="full" and @selection="open" like the Novell plugin does.  They put a radio button with an input field next to it.

Comment 3

12 years ago
I'll try to get this working...
Status: NEW → ASSIGNED
(Assignee)

Comment 4

12 years ago
(In reply to comment #2)
> Created an attachment (id=204749) [edit]
> testcase
> 
> I suggest that we handle select1 with @appearance="full" and @selection="open"
> like the Novell plugin does.  They put a radio button with an input field next
> to it.
> 

When I worked on patch for bug 307627 then I realized select1 @appearance="full". Although I didn't add @selection="open" attribute supporting.

Updated

11 years ago
Blocks: 322255

Updated

11 years ago
Blocks: 326372

Updated

11 years ago
Blocks: 326373
(Assignee)

Comment 5

11 years ago
I want to realize select1 appearance="compact/full" on base of "select-base" widget (It will be possible after bug 323849 fixing). I want to do it withoug @selection="open" supporting. Aaron, can I assign the bug for me?

Comment 6

11 years ago
(In reply to comment #5)
> I want to realize select1 appearance="compact/full" on base of "select-base"
> widget (It will be possible after bug 323849 fixing). I want to do it withoug
> @selection="open" supporting. Aaron, can I assign the bug for me?
> 

sure, you can have this bug.  I haven't done anything with it, yet.  But if you are removing all of the @selection="open" functionality, then make sure you open another bug to put it back in.
Assignee: aaronr → surkov
Status: ASSIGNED → NEW
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 7

11 years ago
Created attachment 217125 [details]
testcase2
(Assignee)

Comment 8

11 years ago
Created attachment 217126 [details] [diff] [review]
patch

the patch adds select1 appearance="compact/full" support without @selection="open" .
Attachment #217126 - Flags: review?(aaronr)
(Assignee)

Updated

11 years ago
Attachment #217126 - Flags: review?(doronr)

Comment 9

11 years ago
Comment on attachment 217126 [details] [diff] [review]
patch

>+
>+
>+  <!-- CONTROL WIDGET FOR SELECT1 APPEARANCE='COMPACT' -->
>+  <binding id="controlwidget-select1-compact"
>+           extends="#controlwidget-select-compact">
>+    <content>
>+      <html:a href="http://">heellele</html:a>
>+      <html:select xbl:inherits="style, accesskey, disabled=readonly"
>+                   class="xf-value" size="5" anonid="control"/>
>+    </content>
>+  </binding>

heellele?  And size="5" for a select1?  I don't think that is what we want for a compat select1?  Size 1 would make more sense.
Attachment #217126 - Flags: review?(doronr) → review-
(Assignee)

Comment 10

11 years ago
Created attachment 217268 [details] [diff] [review]
patch2

(In reply to comment #9)

> heellele?  
Sorry, it's my tests :)

And size="5" for a select1?  I don't think that is what we want for
> a compat select1?  Size 1 would make more sense.
> 
No, just not size 1, size="5" imho looks good (w3c screenshot select1 has size="3" http://www.w3.org/TR/xforms/slice8.html#ui-selectOne)
Attachment #217126 - Attachment is obsolete: true
Attachment #217268 - Flags: review?(doronr)
Attachment #217126 - Flags: review?(aaronr)

Updated

11 years ago
Attachment #217268 - Flags: review?(doronr) → review+
(Assignee)

Updated

11 years ago
Attachment #217268 - Flags: review?(aaronr)

Comment 11

11 years ago
Comment on attachment 217268 [details] [diff] [review]
patch2

remember to open bug on @selection="open" for select1's with @appearance="compact" or "full".

with that, r=me
Attachment #217268 - Flags: review?(aaronr) → review+
(Reporter)

Comment 12

11 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Reporter)

Updated

11 years ago
Keywords: fixed1.8.1
(Reporter)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Reporter)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.