Closed
Bug 303353
Opened 19 years ago
Closed 18 years ago
Support appearance attribute for select1
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: surkov)
References
()
Details
(Keywords: fixed1.8.0.5, fixed1.8.1)
Attachments
(3 files, 1 obsolete file)
We need to support appearance "full", "compact", and "minimal". If we want to look like the examples in the spec. that means we still need "full" and "compact".
Comment 1•19 years ago
|
||
afaik <select> will support full and compact. Perhaps that implementation can be used also with <select1>. Though I'm not sure what the UI should look like when selection="open" and appearance is either full or compact.
Depends on: 300801
I suggest that we handle select1 with @appearance="full" and @selection="open" like the Novell plugin does. They put a radio button with an input field next to it.
Assignee | ||
Comment 4•19 years ago
|
||
(In reply to comment #2) > Created an attachment (id=204749) [edit] > testcase > > I suggest that we handle select1 with @appearance="full" and @selection="open" > like the Novell plugin does. They put a radio button with an input field next > to it. > When I worked on patch for bug 307627 then I realized select1 @appearance="full". Although I didn't add @selection="open" attribute supporting.
Assignee | ||
Comment 5•18 years ago
|
||
I want to realize select1 appearance="compact/full" on base of "select-base" widget (It will be possible after bug 323849 fixing). I want to do it withoug @selection="open" supporting. Aaron, can I assign the bug for me?
(In reply to comment #5) > I want to realize select1 appearance="compact/full" on base of "select-base" > widget (It will be possible after bug 323849 fixing). I want to do it withoug > @selection="open" supporting. Aaron, can I assign the bug for me? > sure, you can have this bug. I haven't done anything with it, yet. But if you are removing all of the @selection="open" functionality, then make sure you open another bug to put it back in.
Assignee: aaronr → surkov
Status: ASSIGNED → NEW
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•18 years ago
|
||
Assignee | ||
Comment 8•18 years ago
|
||
the patch adds select1 appearance="compact/full" support without @selection="open" .
Attachment #217126 -
Flags: review?(aaronr)
Assignee | ||
Updated•18 years ago
|
Attachment #217126 -
Flags: review?(doronr)
Comment 9•18 years ago
|
||
Comment on attachment 217126 [details] [diff] [review] patch >+ >+ >+ <!-- CONTROL WIDGET FOR SELECT1 APPEARANCE='COMPACT' --> >+ <binding id="controlwidget-select1-compact" >+ extends="#controlwidget-select-compact"> >+ <content> >+ <html:a href="http://">heellele</html:a> >+ <html:select xbl:inherits="style, accesskey, disabled=readonly" >+ class="xf-value" size="5" anonid="control"/> >+ </content> >+ </binding> heellele? And size="5" for a select1? I don't think that is what we want for a compat select1? Size 1 would make more sense.
Attachment #217126 -
Flags: review?(doronr) → review-
Assignee | ||
Comment 10•18 years ago
|
||
(In reply to comment #9) > heellele? Sorry, it's my tests :) And size="5" for a select1? I don't think that is what we want for > a compat select1? Size 1 would make more sense. > No, just not size 1, size="5" imho looks good (w3c screenshot select1 has size="3" http://www.w3.org/TR/xforms/slice8.html#ui-selectOne)
Attachment #217126 -
Attachment is obsolete: true
Attachment #217268 -
Flags: review?(doronr)
Attachment #217126 -
Flags: review?(aaronr)
Updated•18 years ago
|
Attachment #217268 -
Flags: review?(doronr) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #217268 -
Flags: review?(aaronr)
Comment 11•18 years ago
|
||
Comment on attachment 217268 [details] [diff] [review] patch2 remember to open bug on @selection="open" for select1's with @appearance="compact" or "full". with that, r=me
Attachment #217268 -
Flags: review?(aaronr) → review+
Reporter | ||
Comment 12•18 years ago
|
||
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Reporter | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Reporter | ||
Updated•18 years ago
|
Keywords: fixed1.8.0.5
Reporter | ||
Updated•18 years ago
|
Whiteboard: xf-to-branch
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•