Closed Bug 303353 Opened 16 years ago Closed 15 years ago

Support appearance attribute for select1

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: surkov)

References

()

Details

(Keywords: fixed1.8.0.5, fixed1.8.1)

Attachments

(3 files, 1 obsolete file)

We need to support appearance "full", "compact", and "minimal". If we want to
look like the examples in the spec. that means we still need "full" and "compact".
afaik <select> will support full and compact. Perhaps that implementation can be
used also with <select1>. Though I'm not sure what the UI should look like
when selection="open" and appearance is either full or compact.
Depends on: 300801
Attached file testcase
I suggest that we handle select1 with @appearance="full" and @selection="open" like the Novell plugin does.  They put a radio button with an input field next to it.
I'll try to get this working...
Status: NEW → ASSIGNED
(In reply to comment #2)
> Created an attachment (id=204749) [edit]
> testcase
> 
> I suggest that we handle select1 with @appearance="full" and @selection="open"
> like the Novell plugin does.  They put a radio button with an input field next
> to it.
> 

When I worked on patch for bug 307627 then I realized select1 @appearance="full". Although I didn't add @selection="open" attribute supporting.
Blocks: 322255
Blocks: 326372
Blocks: 326373
I want to realize select1 appearance="compact/full" on base of "select-base" widget (It will be possible after bug 323849 fixing). I want to do it withoug @selection="open" supporting. Aaron, can I assign the bug for me?
(In reply to comment #5)
> I want to realize select1 appearance="compact/full" on base of "select-base"
> widget (It will be possible after bug 323849 fixing). I want to do it withoug
> @selection="open" supporting. Aaron, can I assign the bug for me?
> 

sure, you can have this bug.  I haven't done anything with it, yet.  But if you are removing all of the @selection="open" functionality, then make sure you open another bug to put it back in.
Assignee: aaronr → surkov
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Attached file testcase2
Attached patch patch (obsolete) — Splinter Review
the patch adds select1 appearance="compact/full" support without @selection="open" .
Attachment #217126 - Flags: review?(aaronr)
Attachment #217126 - Flags: review?(doronr)
Comment on attachment 217126 [details] [diff] [review]
patch

>+
>+
>+  <!-- CONTROL WIDGET FOR SELECT1 APPEARANCE='COMPACT' -->
>+  <binding id="controlwidget-select1-compact"
>+           extends="#controlwidget-select-compact">
>+    <content>
>+      <html:a href="http://">heellele</html:a>
>+      <html:select xbl:inherits="style, accesskey, disabled=readonly"
>+                   class="xf-value" size="5" anonid="control"/>
>+    </content>
>+  </binding>

heellele?  And size="5" for a select1?  I don't think that is what we want for a compat select1?  Size 1 would make more sense.
Attachment #217126 - Flags: review?(doronr) → review-
Attached patch patch2Splinter Review
(In reply to comment #9)

> heellele?  
Sorry, it's my tests :)

And size="5" for a select1?  I don't think that is what we want for
> a compat select1?  Size 1 would make more sense.
> 
No, just not size 1, size="5" imho looks good (w3c screenshot select1 has size="3" http://www.w3.org/TR/xforms/slice8.html#ui-selectOne)
Attachment #217126 - Attachment is obsolete: true
Attachment #217268 - Flags: review?(doronr)
Attachment #217126 - Flags: review?(aaronr)
Attachment #217268 - Flags: review?(doronr) → review+
Attachment #217268 - Flags: review?(aaronr)
Comment on attachment 217268 [details] [diff] [review]
patch2

remember to open bug on @selection="open" for select1's with @appearance="compact" or "full".

with that, r=me
Attachment #217268 - Flags: review?(aaronr) → review+
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Keywords: fixed1.8.1
Keywords: fixed1.8.0.5
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.