The default bug view has changed. See this FAQ.

a11y: Should be able to select items in select1 via keypressed (not arrow keys)

RESOLVED FIXED

Status

Core Graveyard
XForms
--
enhancement
RESOLVED FIXED
12 years ago
8 months ago

People

(Reporter: Allan Beaufour, Assigned: surkov)

Tracking

({fixed1.8.0.8, fixed1.8.1.1})

Trunk
fixed1.8.0.8, fixed1.8.1.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

3.30 KB, application/xhtml+xml
Details
4.31 KB, patch
smaug
: review+
aaronr
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
Pressing f.x. "v" in a select1 should select the first element starting with a
"v", as a html:select does. Try f.x. attachment 190005 [details].

Comment 1

12 years ago
*** Bug 316618 has been marked as a duplicate of this bug. ***

Comment 2

12 years ago
Also, if you type out a value, that value should be selected.
Summary: Should be able to select items in select1 via keypressed (not arrow keys) → a11y: Should be able to select items in select1 via keypressed (not arrow keys)

Updated

11 years ago
Blocks: 326372

Updated

11 years ago
Blocks: 326373
(Reporter)

Updated

11 years ago
Severity: normal → enhancement
(Reporter)

Updated

11 years ago
Assignee: aaronr → xforms
(Assignee)

Updated

11 years ago
Blocks: 337249
(Assignee)

Comment 3

11 years ago
Created attachment 236825 [details]
testcase
Assignee: xforms → surkov.alexander
Status: NEW → ASSIGNED
(Assignee)

Comment 4

11 years ago
Created attachment 236826 [details] [diff] [review]
patch
Attachment #236826 - Flags: review?(Olli.Pettay)
(Assignee)

Comment 5

11 years ago
<method name="selectItemByLabel">
  <parameter name="aValue"/>
  <parameter name="aContextNode"/>

Last parameter is needless. Costs of testing :)

Comment 6

11 years ago
Comment on attachment 236826 [details] [diff] [review]
patch


>+            } else if (aEvent.charCode && !this.selectionOpen) {
>+              // Cache sequence of last pressed keys and search it in value of
>+              // xforms:label inside xforms:item elements.
>+              this.searchedHitCount++;
>+              window.setTimeout(
>+                function(aSelect) {
>+                  if (!--aSelect.searchidHitCount)
>+                    aSelect.searchedValue = "";
>+                },
>+                1000,
>+                this);

Why this timeout is needed? If you have a good reason, add a comment to the code too ;)
And why the timeout is 1sec?
Attachment #236826 - Flags: review?(Olli.Pettay) → review-
(Assignee)

Comment 7

11 years ago
Created attachment 237125 [details] [diff] [review]
patch2

(In reply to comment #6)
> 
> Why this timeout is needed? If you have a good reason, add a comment to the
> code too ;)
> And why the timeout is 1sec?
> 

Right, timeout is not needed. 1 sec is time of html:select http://lxr.mozilla.org/seamonkey/source/layout/forms/nsListControlFrame.cpp#105
Attachment #236826 - Attachment is obsolete: true
Attachment #237125 - Flags: review?(Olli.Pettay)

Updated

11 years ago
Attachment #237125 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

11 years ago
Attachment #237125 - Flags: review?(aaronr)

Updated

11 years ago
Attachment #237125 - Flags: review?(aaronr) → review+
(Assignee)

Comment 8

11 years ago
checked in by smaug for me
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

Comment 9

11 years ago
checked into 1.8.0 branch on 2006/09/21
Keywords: fixed1.8.0.8

Comment 10

10 years ago
checked into 1.8 branch on 2006/11/21
Keywords: fixed1.8.1.1
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.