303928 - Tabbing or arrowing off autocomplete closes selection and location shows last selected entry

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

Steps to reproduce:
1. Activate autocomplete by typing a character
2. Press tab until the last selection
3. Press tab again

Actual: The last entry goes into the location bar and autocomplete closes.
Expected: Original value in location for before autocomplete should be shown
while keeping autocomplete open.

Last working version is from 20050805. Probably caused by fix for bug 302677.

This also happens when shift-tabbing backwards and then the first selection goes
into the location bar. However, pressing down to show a list of history items
then tabbing off does not cause the problem.

Comment 1

[Adam Guthrie]

*** Bug 305279 has been marked as a duplicate of this bug. ***

Comment 2

[Simon Bünzli]

Attachment: prevents detaching the controller

The problem is an unexpected blur event when setting the focus to the
autocomplete widget (on blurring, the search controller is reset and the popup
closed). This hack prevents this through the introduction of one new focus
method which prevents the unwanted consequences of the blur event.

This bug should probably be resolved at the level of the focus infrastructure,
but until then this low risk patch resolves the regression.

Comment 3

[Asaf Romano (gone)]

Was the orginal patch checked in on the brnach? I see this regression on the
branch too.

Comment 4

[Simon Bünzli]

The original patch was checked in before branching. This bug applies to the
trunk and the 1.5 branch, now.

Comment 5

[Chris Beard]

another regression from accessibility changes.  beltzner, mconnor:  could you
please review from a product standpoint and chime in on what the right behaviour
needs to be here?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

IMO, as reporter indicated seems right. So,

- User enters partial string, auto-complete appears
   - TAB, down arrow: move down one entry in list
   - Shift+TAB, up arrow: move up one entry in list
   - the partial string should be the first/last item in the list
   - ESC exits autocomplete mode

If autocomplete mode is exited with ESC, then the URL bar should be set to the
string as entered by the user, not the drop-down selection at the time of the
ESC keystroke. A second ESC should (of course) escape all typing in the URL bar
and return it to its previous state.

Comment 7

[Asaf Romano (gone)]

*** Bug 307659 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 194019 [details] [diff] [review]
prevents detaching the controller

I'm not altogether happy with the overall behaviour/inconsistency here, but
this isn't the time to fight that battle.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

An additional set of steps to reproduce for what I'm pretty sure qualifies as
the same bug (and is being called that in bug 302677):
 * type http://archive.mozilla.org/ in URL bar, press enter
 * type http://archive.mozilla.org/pub/mozilla/ in URL bar, press enter
 * type "archi" in URL bar, press down arrow to go over all the entries

Actual results: after last entry, http://archive.mozilla.org/pub/mozilla/ is in
the URL bar.

Expected results: after last entry, "archi" is in the URL bar.

These steps regressed between 2005-08-05-05-trunk and 2005-08-06-05-trunk.

Comment 10

[Aaron Leventhal]

Comment on attachment 194019 [details] [diff] [review]
prevents detaching the controller

Toolkit patches don't need superreview and I'm not a superreviewer anyway.
You're ready to check into the trunk, but you'll need approval for branch.

Comment 11

[Asa Dotzler [:asa]]

Please land this on the trunk and get the bug resolved so we can verify there
before taking onto the branch. thanks.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/widgets/autocomplete.xml; new revision: 1.46;

Comment 13

[Asaf Romano (gone)]

1.8 Branch:
Checking in autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.44.2.2; previous revision: 1.44.2.1
done