304383 - Caret leaves turds when deleting the last character on a line

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

If you delete the last character on a line, while the caret is visible, the
caret leaves a turd on the line. I suspect the checkin for bug 296464 is the
cause of this.

I think the reason for this is that when you delete the last character (note:
I'm talking about non-wrapped lines), the text frame the caret was in gets
deleted and is replaced with a BR frame, though I'm not certain.

Comment 1

[Mats Palmgren (inactive)]

Yeah, this seems to be a regression from bug 296464.
It's very hard for me to reproduce it though, so I wonder if I see the same
problem as you...

Comment 2

[Mats Palmgren (inactive)]

Attachment: wip

Blake, could you try this patch and see if it fixes it for you?  Thanks.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Yes it does. I'm sorry for taking so long to test it.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Same thing, just added a comment. I'm guessing this fix won't be necessary if
bug 287813 makes the frame responsible for erasing the caret?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193344 [details] [diff] [review]
Patch rev. 1

No need to null-check aChild; in fact you can assert that it's non-null if you
want.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 193344 [details] [diff] [review]
Patch rev. 1

I may have to make sure the parent repaints itself in this case, but I'm not
sure yet.

r=mrbkap

Comment 7

[Mats Palmgren (inactive)]

Checked in on trunk 2005-08-21 17:25 PDT (with comment 5 addressed)

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Could this have caused the orange on Firefox balsa?

Comment 9

[Mats Palmgren (inactive)]

I don't think so, FF/balsa had one green block containing my change.
The block after that was red:
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1124672160&maxdate=1124682239

the next block fixed that but from here on it's orange:
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1124682240&maxdate=1124702519

So it's either of those checkins above, looking at the crash log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1124702520.17969.gz

my guess would be bug 303725

Comment 10

[Matt]

I don't know if this is known, but this bug also appear(s/ed) in the Windows
build as well.  Might have been fixed, but this was a multi-OS bug.

Comment 11

[Mats Palmgren (inactive)]

*** Bug 304640 has been marked as a duplicate of this bug. ***

Comment 12

[Mats Palmgren (inactive)]

Checked in on MOZILLA_1_8_BRANCH at 2005-08-28 22:22 PDT

->FIXED

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on trunk using build 2005-09-01-05, Windows SP SeaMonkey.