Not able to add a bookmark with an empty title, while it is possible to make it empty afterwards

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: Martijn Wargers (zombie))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
This was mentioned here:
http://forums.mozillazine.org/viewtopic.php?t=298128&sid=71d245051c2fc3ec81f7dd2469924b7d

So this should be handled the same, both should not allow an empty name, or they
should allow it both.
My opinion would be to allow it in both places.
(Assignee)

Comment 1

13 years ago
Created attachment 192757 [details] [diff] [review]
patch

Ok, this makes it work for me.
With this I am allowed to add a bookmark with an empty name.
Attachment #192757 - Flags: review?(mconnor)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Assignee: nobody → martijn.martijn
Status: ASSIGNED → NEW
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
If you're getting rid of onFieldInput, you can remove gRequiredFields too, however that would remove the check for a keyword when using "Add a keyword for this search", I don't think that's wanted.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.546&mark=5814#5808
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/bookmarks/content/addBookmark2.js&rev=1.38&mark=126#120

Comment 3

12 years ago
wouldn't it be simpler to just comment out line 71 in addBookmark2.js - seems to do the job, with a whole lot less code.

that line in my 1.5.0.1 release reads:
   gRequiredFields.push(gName);

so... just don't do that...

for the record, this might seem like a pointless feature, but here's why i want it:  i like to have a whole bunch of links on my toolbar, but why not just have the "favicons" up there, i can fit so much more!  who need's text.  currently the procedure for adding a new "bookmark icon" is: 
   1) right-click, "bookmark this page..."
   2) "OK"
   3) right-click new bookmark (freqently on the "spillover" menu on the toolbar), "properties"
   4) erase "name"
   5) OK

changing this file would bring eliminate steps 3-5 but move step 4) to 1b)

coming soon: my bug report search for why you don't get a favicon for new bookmarks until the first time you click it (you get the default "blank page" icon at first)

Comment 4

12 years ago
Created attachment 215628 [details]
Why I like bookmarks with no names.
Attachment #192757 - Attachment is obsolete: true
Attachment #192757 - Flags: review?(mconnor)
Fixed by bug 344459.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Depends on: 344459
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.