305621 - Provide icons that reflect extension's status in the extension manager.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Dave Townsend [:mossop]]

Since bug 305049 it seems that an disable extension gets no icon at all, not
even the green jigsaw. This is probably ok for the time being (branch), but
maybe for trunk it would be worth having a couple of icons for situations.

I would suggest a green jigsaw for standard working extension (as it is now), a
red jigsaw for incompatible extensions and a greyed jigsaw for user disabled
extensions.

Could possibly also have a couple for the situation where an extension is about
to be disabled/enabled but that may be overkill.

Comment 1

[Robert Strong (they/them - no direct email)]

Disabled extensions should get the default extension icon when disabled for
me... please verify whether this works for you and comment in this bug. The
reason they don't get the extension provided icon is due to the extension being
disabled and the extension's icon being a chrome path (e.g. if an extension is
disabled its chrome is not loaded so the extension's icon is not available which
has always been the behavior). All bug 305049 did is stop trying to load
extension provided icons when the extension is disabled.

Comment 2

[Dave Townsend [:mossop]]

Disabled all my extensions and after restart none had any icons, just a blank
space. In safe mode, any normally enabled extensions have the green jigsaw, any
normally disabled have no icon and are greyed out.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823
Firefox/1.6a1 ID:2005082308

Comment 3

[Robert Strong (they/them - no direct email)]

Are you using a theme other than default?

Comment 4

[Robert Strong (they/them - no direct email)]

I just tried using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050823 Firefox/1.0+ ID:2005082311 and the default theme and the default
extension icon was shown for all disabled extensions. I highly suspect you were
using a theme other than default that doesn't supply a default icon in the
location required which would work in safe mode since that will use the default
theme. Sorry for working this out in this bug but this is an important issue you
brought up in the original report and it should be working.

Comment 5

[Dave Townsend [:mossop]]

This is with the default theme. As I said, in safe mode, some of the extensions
got the green jigsaw and others didnt. Just tested again with a totally new
profile, installed a single extension and disabled it and still no icon.

Comment 6

[TimoT]

No icons for me either (using default theme).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050822
Firefox/1.6a1

Trunk only problem?

Comment 7

[Dave Townsend [:mossop]]

Just tested on a build from 21st and this problem does not appear so something
has regressed since your checkin, Rob. Possibly there are theme issues like bug
305632 at work here.
.

Comment 8

[Robert Strong (they/them - no direct email)]

Whew... I thought I was going insane. If it worked on the 21st then it rules out
bug 305049 which was checked in on the 19th

Comment 9

[Robert Strong (they/them - no direct email)]

In regards to using extension icons this would then replace the extension
provided icon when the extension is enabled or not apply to extensions that
provide an icon. If this is to be implemented I would prefer the idea of using a
small icon similar to the one used to denote an extension has an update which
would not replace the extension provided icon.

Comment 10

[Dave Townsend [:mossop]]

That sounds fine. Just to add, the invisible icon issue is gone so it probably
was the same as bug 305632.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Fixed by the magical rewrite. Disabled addons get a grey-scale version of the icon.