305999 - addbook urls no longer work when clicking on vCards in mail

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Send an e-mail to yourself with a vCard.

Click on the add to address book button inside the vCard.

Note that we fail to run the addbook url, and fail to bring up the add to
address book dialog.

Comment 1

[Scott MacGregor]

I believe this is another regression from Bug 244964. Should be easy to fix.

Boris, it looks like 244964 has caused a couple of regressions (Bug 302213, Bug
303336 and now this one). Maybe we should try to audit the code to see if there
are more situations like these. An lxr search on NewInputStreamChannel could be
a good start. 

Patch coming up for this scenario.

Comment 2

[Scott MacGregor]

Attachment: the fix

x-application-addvcard --> application/x-addvcard

Comment 3

[Scott MacGregor]

An lxr search showed quite a few mime types that are now broken after 244964
that problaby need updated:

http://lxr.mozilla.org/mozilla/search?string=x-application-

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193877 [details] [diff] [review]
the fix

r=bzbarsky; I'd tried to look for content-type defines.... :(

Comment 5

[Boris Zbarsky [:bzbarsky]]

> http://lxr.mozilla.org/mozilla/search?string=x-application-

I just checked and all the remaining ones are not passed to SetContentType that
I can see.  It might be a good idea to fix them, but since so many of these
should stop using a made-up type anyway and just do whatever it is they do from
the channel's AsyncOpen method, I think it'd make more sense to spend time on
that instead...

Comment 6

[Scott MacGregor]

Comment on attachment 193877 [details] [diff] [review]
the fix

We need this patch on the branch to fix a regression introduced by Bug 244964.

Low risk, isolated change.

Comment 7

[Scott MacGregor]

fixed on the trunk.

Comment 8

[Scott MacGregor]

thanks for the quick review and for verifying that the other content types
should be ok Boris.