306109 - Expose an inSkinPackage(uri) method on the chrome registry

Status: RESOLVED WONTFIX

(Toolkit :: Startup and Profile System, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now XBL hand-parses chrome: URIs to determine whether a binding is a
"skin" binding.  This is highly suboptimal; the chrome URI syntax should be
opaque to XBL.  See bug 283701 for details; this bug is on providing the chrome
registry hook needed to fix that one.  I'd really like to address this in the
1.9 timeframe, and the chrome registry seems to already have all the regular
code; it just needs to expose it...

Comment 1

[Boris Zbarsky [:bzbarsky]]

er, I meant relevant code, not regular code.  ;)

Comment 2

[Boris Zbarsky [:bzbarsky]]

er, I meant relevant code, not regular code.  ;)

Comment 3

[Benjamin Smedberg]

*** Bug 306110 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that bug 306110 was for the seamonkey chrome registry, while this is for
the toolkit one.  If we kill both birds in this bug, that's fine with me, of course.

Comment 5

[Benjamin Smedberg]

Well, any change will needs be made on nsI(XUL)?ChromeRegistry, so it has to be
done in both at the same time.

Comment 6

[[e-mail]]

So basically you just want to expose nsChromeRegistry::SplitURL?

Comment 7

[Boris Zbarsky [:bzbarsky]]

I want a method I can call to find out whether the binding is in a skin package.
 I'd prefer getting back a boolean so I don't have to know about various
provider types in case we ever change that around in any way, of course.

Comment 8

[Benjamin Smedberg]

How about nsIChromeURI.isSkinPackage ?

Comment 9

[Boris Zbarsky [:bzbarsky]]

> How about nsIChromeURI.isSkinPackage ?

That would probably work ok in this case.  As long as we never have to worry
about resource: URIs and so forth pointing into skin packages, that should be
enough, I guess.

Comment 10

[Wayne Mery (:wsmwk)]

still sev major?  the bug it blocks is only sev=minor with no activity for 3yr

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 13

[Dave Townsend [:mossop]]

This is no longer needed