306288 - Security UI callbacks for embedders have no useful context information

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Simon Fraser [no longer active]]

For an embedder implementing nsICertificateDialogs, nsIBadCertListener or
nsISecurityWarningDialogs, there's no way to get at the originating nsIDOMWindow
from the various callback methods. This is a serious security issue, because the
emedder cannot preset UI to the user that indicates where the request is coming
from.

For our other dialogs (via nsIPromptService) we are provided an nsIDOMWindow.
NSS/PSM needs to do the same.

The provided nsIInterfaceRequestor* ctx is not useful; it's only queryable to an
nsIPrompt.

Comment 1

[Doug Turner (:dougt)]

in:
http://lxr.mozilla.org/seamonkey/source/security/manager/pki/src/nsNSSDialogs.cpp

we seam to be doing something like:
nsCOMPtr<nsIDOMWindowInternal> parent = do_GetInterface(ctx);

Is this not working for you?

Comment 2

[Simon Fraser [no longer active]]

(In reply to comment #1)
> in:
> http://lxr.mozilla.org/seamonkey/source/security/manager/pki/src/nsNSSDialogs.cpp
> 
> we seam to be doing something like:
> nsCOMPtr<nsIDOMWindowInternal> parent = do_GetInterface(ctx);
> 
> Is this not working for you?

I just debugged through this in DeerPark. |parent| there in
nsNSSDialogs::ConfirmDownloadCACert() is a null pointer (note that the code
doesn't check it).

Comment 3

[Doug Turner (:dougt)]

Very odd.  Tracing back a bit on the stack, don't you see a new'ed PipUIContext
on either:

http://lxr.mozilla.org/seamonkey/source/security/manager/ssl/src/nsNSSComponent.cpp#2428
http://lxr.mozilla.org/seamonkey/source/security/manager/ssl/src/nsNSSCertificateDB.cpp#1029

In any case, your right... this object doesn't really get you to where you need
to be.

Comment 4

[Simon Fraser [no longer active]]

Yeah, PipUIContext is a waste of space.

Comment 5

[Daniel Veditz [:dveditz]]

Can we clear the security-sensitive flag? What are we protecting here?

Comment 6

[Simon Fraser [no longer active]]

Sure. Just trying to be paranoid.

Comment 7

[Simon Fraser [no longer active]]

Bug 277587 may have helped.

Comment 8

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #7)
> Bug 277587 may have helped.
> 

That fixed it for the interface requestor passed to nsISecurityWarningDialogs methods; all others still have the problem.

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler]]

This doesn't seem to be relevant anymore.