30633 - Modal dialogs causes submenu > image in menu to display too large

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Enter http://127.0.0.1:600/ into the location bar to get a modal dialog.
2. Try to pull down tasks menu 

Mozilla will sometimes display the submenus with really big '>' thingies 
instead of small ones. Also, it will only sometimes let you pull down the menus 
(alt-tabbing away from mozilla and back often makes it allow you to pull them 
down).

May be related to bug #21296.

Comment 1

[Asa Dotzler [:asa]]

Confirmed on 3/5 under winNT.  The ">" black triangle signifying sub menus is 
really big when a modal dialog is open.  I remember this happening a while back 
but I can't find the bug and lots has changed since I saw this last.  Changing 
component to XP Menus and confirming (to move to new status).

Comment 2

[Asa Dotzler [:asa]]

changing summary to be a bit more descriptive.  adding self to cc list and 
assigning to component owner. 

Comment 3

[Mike Pinkerton (not reading bugmail)]

why can you get to menus at all when you have a modal dialog up? that's not right 
(at least win32/linux). i'm going to mark this invalid unless i'm 
misunderstanding something.

Comment 4

[sairuh (rarely reading bugmail)]

weird but true: at least when using winNT [2000.03.13.18-nb1b, opt comm], i can
bring up the Tasks menu (and *only* the Tasks menu).

Comment 5

[Mike Pinkerton (not reading bugmail)]

dan?

Comment 6

[Dan M]

I can't speak for why the images are a different size, but I can speak about why 
the parent window's menus are functional. In rev 1.21, Travis for some reason 
removed the line in nsXULWindow::ShowModal responsible for the modal behaviour. 
That line doesn't want to be removed. Did you really need it gone for some 
reason?

Comment 7

[Jesse Ruderman]

Well, most "modal" dialogs that Mozilla will bring up can be popped up by a 
website, so the user should at least be able to leave the page or close the 
browser.  Admittadly, those actions doesn't require use of menus, but unless 
bug 29346 is fixed access to file|quit (close all) will continue to be useful.

Sites aren't limited to javascript alerts and prompts to bring up modal 
dialogs - a site might keep trying to redirect to a nonexistant site, for 
example.

(Anyway, why not fix this bug at P5?  How do you know that it _only_ shows up 
when modal dialogs are in front?)

Comment 8

[Dan M]

.

Comment 9

[Dan M]

I agree: once obnoxious content providers discover the "modal" flag, Mozilla will 
be unuseable on obnoxious content. Bug 29346 will be a nice addition to the fray, 
but we also need to disable the ability to make a modal dialog by unsigned 
content JS. As it is, unmodal modal dialogs are causing lots of problems 
(recently filed bug 33129, for instance.) I've just restored modal window 
modality. JS security to the rescue for these other problems.

Comment 10

[sairuh (rarely reading bugmail)]

verified with winNT opt comm bits: 2000.03.28.09