Closed
Bug 306538
Opened 19 years ago
Closed 19 years ago
Autocomplete doesn't work without a mousemove event
Categories
(Toolkit :: Autocomplete, defect)
Toolkit
Autocomplete
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: dougt, Assigned: dougt)
References
Details
(Keywords: fixed1.8.1, testcase)
Attachments
(2 files, 1 obsolete file)
1.22 KB,
patch
|
mconnor
:
first-review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
631 bytes,
text/html
|
Details |
It seams that the autocomplete widget will not work if it doesn't receive a mousemove event. There are some users that uses a pen or other device which doesn't allow mouse movement or dragging. Basically in FireFox, if you use a tablet PC; or in Minimo on a phone or PDA, you can click on the textbox type="autocomplete" widget, which brings up a popup containing all of your history. If you simple click without generating a mousemove, the selected item would have never be selected and your click would close the popup as a noop. I think the fix is to treat the mousedown event in the same exact way as we do the mousemove event. I tested this theory out and it works find. Basically what i did was on line 773 of mozilla/toolkit/content/widgets/autocomplete.xml, i duplicated the mousemove handler and renamed one to be mousedown. There might be a cleaner way to do this. Any suggestions, Mike?
Comment 1•19 years ago
|
||
For my similar effect in bug 178091 I simply made the click do an extra update.
Assignee | ||
Comment 2•19 years ago
|
||
just duplicating the mousemove handler and naming it mousedown. there is probably a cleaner way. this patch works for me.
Comment 3•19 years ago
|
||
Comment on attachment 194666 [details] [diff] [review] patch v.1 >+ var rc = this.getHoverCell(event); >+ if (rc && rc.row != this.parentNode.currentIndex) >+ this.parentNode.view.selection.select(rc.row); I don't think you need to duplicate the whole method, just this bit.
Assignee | ||
Comment 4•19 years ago
|
||
Attachment #194666 -
Attachment is obsolete: true
Attachment #194715 -
Flags: first-review?(neil.parkwaycc.co.uk)
Updated•19 years ago
|
Attachment #194715 -
Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
Assignee | ||
Comment 5•19 years ago
|
||
thanks mike: Checking in content/widgets/autocomplete.xml; /cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v <-- autocomplete.xml new revision: 1.47; previous revision: 1.46 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 6•19 years ago
|
||
I think this also fixed this testcase. Follow the steps in the testcase to reproduce the bug. This was a problem that also caught me quite often in the wild (probably had gmail in a background tab). So maybe this patch is also useful on branch?
Comment 7•19 years ago
|
||
Yeah, this testcase is now WFM Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050920 Firefox/1.6a1
Comment 8•19 years ago
|
||
Sorry, this one slipped off my radar because I went on holiday (and I'm still 75 bugmails behind, sigh...)
Comment 9•19 years ago
|
||
I think this patch would be also very useful on branch. I very much suspect it would also fix bug 249763 and bug 174489. Doug, care to ask approval 1.8b5? for it?
Assignee | ||
Comment 10•19 years ago
|
||
should be considered. It is a low risk, high gain patch.
Flags: blocking1.8b5?
Flags: blocking1.8.1?
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5-
Comment 14•19 years ago
|
||
I'm nominating for the branch since this bug has: 1) baked on the truck for over a month and a half 2) is a low risk, high gain patch (comment 10) 3) affects normal users, not just tablets, PDAs, etc. (see below) Imagine you're using a well known form (e.g. a Bugzilla bug entry) and doing something you do all the time (e.g. add yourself to the CC list). You click in the field, move the mouse to where you know the entry you want will be, hit the first letter of the entry and then click. If you didn't happen to move the mouse after hitting the first letter, the textbox doesn't get filled in. Here are the steps to reproduce: 1. Set focus to a textbox that has autocomplete entries. 2. Position the mouse such that it will be over an entry from the dropdown when it appears. 3. Enter a character that will cause autocomplete to show. *Do not move the mouse*. 4. Click without moving the mouse. Since the entries highlight on mouse move, no entry will be selected. Clicking will dismiss the dropdown without populating the textbox. These steps may seem somewhat contrived, but it happens (at least to me) more often than one might think.
Flags: blocking1.8rc2?
Comment 15•19 years ago
|
||
Ron, To request 1.8 branch approval of this patch, you need to set the "approval1.8rc2" flag on the patch to '?'. "blocking1.8rc2" is just used for tagging the actual bug that blocks the said release, not for approval of the patch into the branch.
Comment 16•19 years ago
|
||
(In reply to comment #15) > Ron, > To request 1.8 branch approval of this patch, you need to set the > "approval1.8rc2" flag on the patch to '?'. "blocking1.8rc2" is just used for > tagging the actual bug that blocks the said release, not for approval of the > patch into the branch. I'd set the approval flag on the patch, but I don't have rights (which seems silly that I can nominate a bug to block, but not nominate a patch to land--but I digress). Anyone with rights want to set the flag?
Comment 18•19 years ago
|
||
This isn't a show stopper which would cause us to respin the final 1.5 bits.
Flags: blocking1.8rc2? → blocking1.8rc2-
Comment 19•19 years ago
|
||
Comment on attachment 194715 [details] [diff] [review] patch v.2 We should take this on the branch for Firefox 2.
Attachment #194715 -
Flags: approval1.8.1?
Updated•19 years ago
|
Flags: blocking1.8.0.2?
Updated•19 years ago
|
Attachment #194715 -
Flags: approval1.8.1? → branch-1.8.1+
Comment 20•19 years ago
|
||
Checked this in on the branch for Firefox 2. mozilla/toolkit/content/widgets/autocomplete.xml; new revision: 1.44.2.4;
Comment 21•19 years ago
|
||
Doesn't appear to fit the criteria for a security/stability release
Flags: blocking1.8.0.2? → blocking1.8.0.2-
You need to log in
before you can comment on or make changes to this bug.
Description
•