306643 - Restructure installation routine

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[alanjstr]

http://lxr.mozilla.org/webtools/source/addons/js/install.js#2
http://lxr.mozilla.org/webtools/source/update/core/inc_global.php#187
http://lxr.mozilla.org/webtools/source/update/core/inc_global.php#211

We need to ditch XMLHttpRequest.  We're not using it and its causing problems.

Comment 1

[alanjstr]

Attachment: Remove xmlhttprequest from UMO 1.0

Comment 2

[alanjstr]

Bug 295366 is an alternative

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Are we really not using it?  bsmedberg told me changing the "false" to "true"
will make it an asynchronous request which should alleviate at least some of the
problems...

Comment 4

[alanjstr]

Asynch handling would be bug 295366.  But even in your patch for that, you
ignore the error.

Comment 5

[Giorgio Maone [:ma1]]

Comment on attachment 194499 [details] [diff] [review]
Remove xmlhttprequest from UMO 1.0

Aehm... this patch removes download count all together! You're going to provide
a download count alternate code path before committing this, aren't you?

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #4)
> Asynch handling would be bug 295366.  But even in your patch for that, you
> ignore the error.

Is there any reason just changing false/true wouldn't be adequate?

(In reply to comment #5)
> (From update of attachment 194499 [details] [diff] [review] [edit])
> Aehm... this patch removes download count all together! You're going to provide
> a download count alternate code path before committing this, aren't you?
> 

I don't like this patch for that reason.

Comment 7

[alanjstr]

Comment on attachment 194499 [details] [diff] [review]
Remove xmlhttprequest from UMO 1.0

I don't like the patch for that reason either.

Comment 8

[Frank Yan (:fryn)]

(In reply to comment #0)
> 
> We need to ditch XMLHttpRequest.  We're not using it and its causing problems.

would this affect Greasemonkey?

Comment 9

[alanjstr]

Actually, we do use it, its just that it causes problems.  We're talking about
the website, not removing it from the browser.

Comment 10

[Michael Morgan [:morgamic]]

See new version:
http://lxr.mozilla.org/mozilla/source/webtools/addons/public/htdocs/js/install.js

If there are still issues, reopen.  Thanks.

Comment 11

[Michael Morgan [:morgamic]]

The problem was that the installation functions were causing unnecessary delays.  This has been fixed by:
a) removing maintenance queries from install.php
c) making the request call asynchronous (s/false/true/)

Comment 12

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)

Comment 13

[Reed Loden [:reed]]

AMO BUGSPAM FOR QACONTACT FIX (FILTER ME)