Restructure installation routine

RESOLVED FIXED in 1.0

Status

addons.mozilla.org Graveyard
Public Pages
--
critical
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: alanjstr, Assigned: alanjstr)

Tracking

Dependency tree / graph

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
http://lxr.mozilla.org/webtools/source/addons/js/install.js#2
http://lxr.mozilla.org/webtools/source/update/core/inc_global.php#187
http://lxr.mozilla.org/webtools/source/update/core/inc_global.php#211

We need to ditch XMLHttpRequest.  We're not using it and its causing problems.
(Assignee)

Comment 1

12 years ago
Created attachment 194499 [details] [diff] [review]
Remove xmlhttprequest from UMO 1.0
Attachment #194499 - Flags: first-review?(cst)
(Assignee)

Comment 2

12 years ago
Bug 295366 is an alternative
Are we really not using it?  bsmedberg told me changing the "false" to "true"
will make it an asynchronous request which should alleviate at least some of the
problems...
(Assignee)

Comment 4

12 years ago
Asynch handling would be bug 295366.  But even in your patch for that, you
ignore the error.
Status: NEW → ASSIGNED

Comment 5

12 years ago
Comment on attachment 194499 [details] [diff] [review]
Remove xmlhttprequest from UMO 1.0

Aehm... this patch removes download count all together! You're going to provide
a download count alternate code path before committing this, aren't you?
(In reply to comment #4)
> Asynch handling would be bug 295366.  But even in your patch for that, you
> ignore the error.

Is there any reason just changing false/true wouldn't be adequate?

(In reply to comment #5)
> (From update of attachment 194499 [details] [diff] [review] [edit])
> Aehm... this patch removes download count all together! You're going to provide
> a download count alternate code path before committing this, aren't you?
> 

I don't like this patch for that reason.
(Assignee)

Comment 7

12 years ago
Comment on attachment 194499 [details] [diff] [review]
Remove xmlhttprequest from UMO 1.0

I don't like the patch for that reason either.
Attachment #194499 - Flags: first-review?(cst)

Comment 8

12 years ago
(In reply to comment #0)
> 
> We need to ditch XMLHttpRequest.  We're not using it and its causing problems.

would this affect Greasemonkey?
(Assignee)

Comment 9

12 years ago
Actually, we do use it, its just that it causes problems.  We're talking about
the website, not removing it from the browser.
See new version:
http://lxr.mozilla.org/mozilla/source/webtools/addons/public/htdocs/js/install.js

If there are still issues, reopen.  Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The problem was that the installation functions were causing unnecessary delays.  This has been fixed by:
a) removing maintenance queries from install.php
c) making the request call asynchronous (s/false/true/)
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
Summary: Remove XMLHttpRequest → Restructure installation routine
AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)
Component: Listings → Web Site
AMO BUGSPAM FOR QACONTACT FIX (FILTER ME)
QA Contact: listings → web-ui
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.