307315 - JS labeled as version 1.6 does't work

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[nanto_vi (TOYAMA Nao)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050906 Firefox/1.4

(I'm not sure what the component of this bug should be.)

In bug 306664, JS 1.6 support was added.  But on 2005090618 branch,

<script type="application/javascript; version=1.6">

doesn't work at all, and

<script language="JavaScript1.6">

works, but E4X support is not enabled.

Reproducible: Always

Steps to Reproduce:

Comment 1

[nanto_vi (TOYAMA Nao)]

Attachment: testcase

Testcase for:
<script type="application/javascript; version=1.6">
<script language="JavaScript1.6">
<script type="application/javascript; e4x=1">

Comment 2

[Brendan Eich [:brendan]]

Argh!  I forgot to check in jsapi.c.

However, language="JavaScript1.6" is not working because (see bug 255895) no
other browser respects the version suffix, and language is deprecated.  Please
correct me if I'm wrong, and some other browser ignores tag content (...) for
<script language="JavaScript1.6">...</script>.

This is worth getting right for beta1, and easy to fix.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: the missing file-patch

Grrr.

I need sleep (again).  Will try tomorrow if there is a respin for 1.8b4.

/be

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 195116 [details] [diff] [review]
the missing file-patch

sr=shaver

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 195116 [details] [diff] [review]
the missing file-patch

r=mrbkap

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 195116 [details] [diff] [review]
the missing file-patch

we're gonna respin so there's a shot at getting this in if it happens real
soon.

Comment 7

[Brendan Eich [:brendan]]

Fixed brunch and trank.  Er, zzzz (I actually typed that! ;-).

/be

Comment 8

[Brendan Eich [:brendan]]

David, see comment 2 second paragraph, and the bug to which it links.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

Attachment: testcase 2

ff 1.4/winxp after today's respin
=================================
application/x-javascript
application/x-javascript;version=1.6
application/javascript
application/javascript;version=1.6
text/javascript
text/javascript;version=1.6
application/ecmascript
application/ecmascript;version=1.6
text/ecmascript
text/ecmascript;version=1.6

msie6/winxp
=================================
text/javascript
text/ecmascript

opera8/winxp
=================================
application/x-javascript
text/x-javascript
text/javascript
text/ecmascript

Comment 10

[Bob Clary [:bc] (inactive)]

There is no single test, but the entire js1_6 section run in the browser tests this.