307392 - RSS account should have "Disk Space" (retention) settings like other accounts

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Mike Cowperthwaite]

Each RSS folder has the Retention Policy tab which has as its first setting:
   [] Use server defaults

However, the RSS account does not have a Disk Space page where the server 
settings for retention can be set.

Comment 1

[Mike Cowperthwaite]

*** Bug 323914 has been marked as a duplicate of this bug. ***

Comment 2

[Mike Cowperthwaite]

Also lacking a field to set the Local Directory, like other account types do; this is bug 340324.

Comment 3

[JongAm Park]

I agree. I would like to see this feature is prepared for the thunderbird.

Comment 4

[Mike Cowperthwaite]

Scott, I know this is a request for some additional code, but it would be a nice thing to get in and shouldn't be too difficult.

Comment 6

[Magnus Melin [:mkmelin]]

Have a patch for this.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Enables the "Disk space" section for RSS accounts. I guess it was an oversight to disable it to start with - the backend supports retention policy for feeds just fine AFAIKT, it's even shown in the folder properties.

Comment 8

[David :Bienvenu]

Comment on attachment 324845 [details] [diff] [review]
proposed fix

cool, yeah, we should have always had this.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 324845 [details] [diff] [review]
proposed fix

So I've just applied this on my mac build.

On the Disk Space pane of news and blogs, I see:

* an Offline section, which doesn't appear to relate to News and Blogs
* two "To save disk space, do not download" titles (one has for offline use) and a set of boxes for Read messages, messages larger than, message more than. I think at least the Read messages doesn't really apply to rss feeds.

As a result (probably of the first one, but maybe also the extra title in in the disk space section), the preferences are slightly too long for the dialog.

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: screenshot with the patch

Comment 11

[Magnus Melin [:mkmelin]]

Mark, sure you applied all of the patch? Above is a screenshot of the way it looks for me.

Comment 12

[Mark Banner (:standard8)]

(In reply to comment #11)
> Mark, sure you applied all of the patch? Above is a screenshot of the way it
> looks for me.
> 
Hmm, I wonder if I forgot to rebuild in mailnews/. Ok, I'll check it again later.

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 324845 [details] [diff] [review]
proposed fix

Yep I guess I missed building something. r=me.

Comment 14

[Magnus Melin [:mkmelin]]

Checking in mailnews/base/prefs/resources/content/am-offline.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-offline.xul,v  <--  am-offline.xul
new revision: 1.32; previous revision: 1.31
done
Checking in mailnews/base/src/nsMsgAccountManagerDS.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgAccountManagerDS.cpp,v  <--  nsMsgAccountManagerDS.cpp
new revision: 1.119; previous revision: 1.118
done
Checking in mailnews/local/src/nsRssIncomingServer.cpp;
/cvsroot/mozilla/mailnews/local/src/nsRssIncomingServer.cpp,v  <--  nsRssIncomingServer.cpp
new revision: 1.21; previous revision: 1.20
done

->FIXED

Comment 15

[Mike Cowperthwaite]

V 3pre2-0621

Thank you, Magnus!