Closed Bug 307436 Opened 19 years ago Closed 19 years ago

app update window is too narrow to fit the UI

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: jaas, Assigned: jaas)

Details

(Keywords: late-l10n, verified1.8)

Attachments

(1 file, 2 obsolete files)

fix v2.1
1.66 KB, patch
asaf
: review+
beng.bugs
: superreview+
mscott
: approval1.8b5+
Details | Diff | Splinter Review 
If you use Thunderbird's application update system, you'll see that the text and
a button gets cut off when you get to the frame about restarting Thunderbird.
Attached patch fix v1.0 (obsolete) — — Splinter Review 
This should do it. We might want to bump the mac em value to 40 if people don't
like 39. In any case, this patch should do it for the worst of the problem.
Attachment #195203 - Flags: superreview?(mscott)
Attachment #195203 - Flags: review?(bugs.mano)
Flags: blocking1.8b5?
Comment on attachment 195203 [details] [diff] [review]
fix v1.0

This has to be localizable (That's, 39/36em isn't going to work for all
locales).
Attachment #195203 - Flags: review?(bugs.mano) → review-
Attachment #195203 - Flags: superreview?(mscott)
Attached patch fix v2.0 (obsolete) — — Splinter Review 
I've never played with localizing before, so take it easy on me :)

This appears to work.
Attachment #195203 - Attachment is obsolete: true
Attachment #195210 - Flags: review?(bugs.mano)
Comment on attachment 195210 [details] [diff] [review]
fix v2.0

>Index: locales/en-US/chrome/mozapps/update/updates.dtd
>===================================================================

>@@ -1,5 +1,8 @@
> <!ENTITY  updateWizard.title              "Software Update">
> 
>+<!ENTITY  window.width                    "36">
>+<!ENTITY  window.macWidth                 "39">
>+

36em and 39em.

>Index: mozapps/update/content/updates.xul
>===================================================================
36em;"
>+#ifdef XP_MACOSX
>+        windowtype="Update:Wizard" style="width: &window.macWidth;"
>+#else
>+        windowtype="Update:Wizard" style="width: &window.width;"
>+#endif

missing semicolon in both.
Attachment #195210 - Flags: review?(bugs.mano) → review-
Attached patch fix v2.1 — — Splinter Review 
fixes things Mano pointed out
Attachment #195210 - Attachment is obsolete: true
Attachment #195213 - Flags: review?(bugs.mano)
Comment on attachment 195213 [details] [diff] [review]
fix v2.1

r=mano.
Attachment #195213 - Flags: review?(bugs.mano) → review+
Attachment #195213 - Flags: superreview?(mscott)
Attachment #195213 - Flags: superreview?(mscott) → superreview?(bugs)
Comment on attachment 195213 [details] [diff] [review]
fix v2.1

sr=ben@mozilla.org
Attachment #195213 - Flags: superreview?(bugs) → superreview+
landed on trunk, still needs a branch landing
feel free to check it into the branch after we re-open for branch checkins.
Flags: blocking1.8b5? → blocking1.8b5+
Target Milestone: --- → Thunderbird1.1
Attachment #195213 - Flags: approval1.8b5+
checked in on branch
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Keywords: late-l10n
Keywords: fixed1.8
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: