app update window is too narrow to fit the UI

VERIFIED FIXED in Thunderbird1.1

Status

Thunderbird
General
--
major
VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

({late-l10n, verified1.8})

Trunk
Thunderbird1.1
PowerPC
Mac OS X
late-l10n, verified1.8
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

1.66 KB, patch
mano
: review+
Ben Goodger (Sorta Watching)
: superreview+
Scott MacGregor
: approval1.8b5+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
If you use Thunderbird's application update system, you'll see that the text and
a button gets cut off when you get to the frame about restarting Thunderbird.
(Assignee)

Comment 1

13 years ago
Created attachment 195203 [details] [diff] [review]
fix v1.0

This should do it. We might want to bump the mac em value to 40 if people don't
like 39. In any case, this patch should do it for the worst of the problem.
Attachment #195203 - Flags: superreview?(mscott)
Attachment #195203 - Flags: review?(bugs.mano)
(Assignee)

Updated

13 years ago
Flags: blocking1.8b5?
Comment on attachment 195203 [details] [diff] [review]
fix v1.0

This has to be localizable (That's, 39/36em isn't going to work for all
locales).
Attachment #195203 - Flags: review?(bugs.mano) → review-
(Assignee)

Updated

13 years ago
Attachment #195203 - Flags: superreview?(mscott)
(Assignee)

Comment 3

13 years ago
Created attachment 195210 [details] [diff] [review]
fix v2.0

I've never played with localizing before, so take it easy on me :)

This appears to work.
Attachment #195203 - Attachment is obsolete: true
Attachment #195210 - Flags: review?(bugs.mano)
Comment on attachment 195210 [details] [diff] [review]
fix v2.0

>Index: locales/en-US/chrome/mozapps/update/updates.dtd
>===================================================================

>@@ -1,5 +1,8 @@
> <!ENTITY  updateWizard.title              "Software Update">
> 
>+<!ENTITY  window.width                    "36">
>+<!ENTITY  window.macWidth                 "39">
>+

36em and 39em.

>Index: mozapps/update/content/updates.xul
>===================================================================
36em;"
>+#ifdef XP_MACOSX
>+        windowtype="Update:Wizard" style="width: &window.macWidth;"
>+#else
>+        windowtype="Update:Wizard" style="width: &window.width;"
>+#endif

missing semicolon in both.
Attachment #195210 - Flags: review?(bugs.mano) → review-
(Assignee)

Comment 5

13 years ago
Created attachment 195213 [details] [diff] [review]
fix v2.1

fixes things Mano pointed out
Attachment #195210 - Attachment is obsolete: true
Attachment #195213 - Flags: review?(bugs.mano)
Comment on attachment 195213 [details] [diff] [review]
fix v2.1

r=mano.
Attachment #195213 - Flags: review?(bugs.mano) → review+
(Assignee)

Updated

13 years ago
Attachment #195213 - Flags: superreview?(mscott)
(Assignee)

Updated

13 years ago
Attachment #195213 - Flags: superreview?(mscott) → superreview?(bugs)
Comment on attachment 195213 [details] [diff] [review]
fix v2.1

sr=ben@mozilla.org
Attachment #195213 - Flags: superreview?(bugs) → superreview+
(Assignee)

Comment 8

13 years ago
landed on trunk, still needs a branch landing

Comment 9

13 years ago
feel free to check it into the branch after we re-open for branch checkins.
Flags: blocking1.8b5? → blocking1.8b5+
Target Milestone: --- → Thunderbird1.1

Updated

13 years ago
Attachment #195213 - Flags: approval1.8b5+
(Assignee)

Comment 10

13 years ago
checked in on branch
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Keywords: late-l10n

Updated

13 years ago
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.