307447 - White line appears at the top of the help window and Error Console (bug 301039 was backed out)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[John Hawkins]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

Help window now has a 2-3 pixel white line at the top that was not visible in
earlier nightlies.

Reproducible: Always

Steps to Reproduce:
1. Open Help->Help Contents
2. See white line @ top of window
3. File bug report

Actual Results:  
White line appeared.

Expected Results:  
No white line should appear.

Comment 1

[John Hawkins]

Attachment: Screenshot of previously mentioned white line in help dialog

Comment 2

[Bryan]

(In reply to comment #1)
> Created an attachment (id=195218) [edit]
> Screenshot of previously mentioned white line in help dialog
> 

This has been there for months.  It also exists in the JavaScript Console.  I
fixed it in https://bugzilla.mozilla.org/show_bug.cgi?id=301039 but Ben G.
reverted it back by removing that specific fix.  I have no clue as to why he did
that.  No real explanation was given.  

~B

Comment 3

[Ria Klaassen (not reading all bugmail)]

In the default WinXP theme I see only a one pixel white line. Maybe meant as
(reflecting) light?
Screenshot with enlargement: http://img153.imageshack.us/img153/3977/help4ps.png

Comment 4

[Asa Dotzler [:asa]]

not going to block on this though I'm sure we'd consider a fully reviewed fix if
it's low risk.

Comment 5

[Bryan]

The following changes to toolbar.css will fix this issue once and for all!

-  border-top: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;
 }
 
 /* ::::: toolbar & menubar ::::: */
 
 toolbar {
   min-width: 1px;
   min-height: 19px;
   border-top: 1px solid ThreeDHighlight;
   border-bottom: 1px solid ThreeDShadow;
 }
 
 toolbar[type="menubar"], menubar {
   min-width: 1px;
   border-bottom: 1px solid ThreeDShadow;
-  border-top: 0px !important;
+}
+
+toolbox > toolbar:first-child, toolbox > menubar:first-child {
+  border-top: 2px solid;
+  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;
 }

~B

Comment 6

[Simon Bünzli]

Attachment: don't assume the first toolbar is always a menubar

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checked this in on the 1.8 branch. Is this relevant to the trunk? It doesn't apply there.
mozilla/toolkit/themes/winstripe/global/toolbar.css 	1.7.2.6

Comment 8

[Bryan]

(In reply to comment #7)
> Checked this in on the 1.8 branch. Is this relevant to the trunk? It doesn't
> apply there.
> mozilla/toolkit/themes/winstripe/global/toolbar.css     1.7.2.6
> 
I believe this issue does exist on the trunk as well.  I'm not sure if this patch will apply on the trunk though.

~B

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> I believe this issue does exist on the trunk as well.  I'm not sure if this
> patch will apply on the trunk though.

It won't. That's what I said in comment 7.

Comment 10

[Simon Bünzli]

This isn't relevant on the trunk. Should you get the same issue there, please file a regression against bug 313388 (Windows Classic only).