Closed Bug 307447 Opened 16 years ago Closed 15 years ago

White line appears at the top of the help window and Error Console (bug 301039 was backed out)

Categories

(Firefox :: Toolbars and Customization, defect)

2.0 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 beta1

People

(Reporter: jhawkins002, Assigned: zeniko)

Details

(Keywords: fixed1.8.1, regression)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050907 Firefox/1.4

Help window now has a 2-3 pixel white line at the top that was not visible in
earlier nightlies.

Reproducible: Always

Steps to Reproduce:
1. Open Help->Help Contents
2. See white line @ top of window
3. File bug report

Actual Results:  
White line appeared.

Expected Results:  
No white line should appear.
(In reply to comment #1)
> Created an attachment (id=195218) [edit]
> Screenshot of previously mentioned white line in help dialog
> 

This has been there for months.  It also exists in the JavaScript Console.  I
fixed it in https://bugzilla.mozilla.org/show_bug.cgi?id=301039 but Ben G.
reverted it back by removing that specific fix.  I have no clue as to why he did
that.  No real explanation was given.  

~B
In the default WinXP theme I see only a one pixel white line. Maybe meant as
(reflecting) light?
Screenshot with enlargement: http://img153.imageshack.us/img153/3977/help4ps.png
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Since bug #303806 checkin, help window now shows mysterious white line @ top → white line appears at the top of the help window and javascript console (bug 301039 was backed out)
Version: unspecified → 1.5 Branch
not going to block on this though I'm sure we'd consider a fully reviewed fix if
it's low risk.
Flags: blocking1.8b5? → blocking1.8b5-
The following changes to toolbar.css will fix this issue once and for all!

-  border-top: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;
 }
 
 /* ::::: toolbar & menubar ::::: */
 
 toolbar {
   min-width: 1px;
   min-height: 19px;
   border-top: 1px solid ThreeDHighlight;
   border-bottom: 1px solid ThreeDShadow;
 }
 
 toolbar[type="menubar"], menubar {
   min-width: 1px;
   border-bottom: 1px solid ThreeDShadow;
-  border-top: 0px !important;
+}
+
+toolbox > toolbar:first-child, toolbox > menubar:first-child {
+  border-top: 2px solid;
+  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;
 }

~B
Summary: white line appears at the top of the help window and javascript console (bug 301039 was backed out) → White line appears at the top of the help window and Error Console (bug 301039 was backed out)
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #224684 - Flags: review?(kevin)
Attachment #224684 - Flags: review?(kevin)
Attachment #224684 - Flags: review+
Attachment #224684 - Flags: approval-branch-1.8.1+
Whiteboard: [checkin needed]
Checked this in on the 1.8 branch. Is this relevant to the trunk? It doesn't apply there.
mozilla/toolkit/themes/winstripe/global/toolbar.css 	1.7.2.6
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 2 beta1
Version: 1.5.0.x Branch → 2.0 Branch
(In reply to comment #7)
> Checked this in on the 1.8 branch. Is this relevant to the trunk? It doesn't
> apply there.
> mozilla/toolkit/themes/winstripe/global/toolbar.css     1.7.2.6
> 
I believe this issue does exist on the trunk as well.  I'm not sure if this patch will apply on the trunk though.

~B
(In reply to comment #8)
> I believe this issue does exist on the trunk as well.  I'm not sure if this
> patch will apply on the trunk though.

It won't. That's what I said in comment 7.
This isn't relevant on the trunk. Should you get the same issue there, please file a regression against bug 313388 (Windows Classic only).
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.