307877 - When mouse pass over the close tab button, control is too big

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Cedric]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6) Mnenhy/0.7.1
Build Identifier: Mozilla 1.5 beta 1 but show : Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.10) Gecko/20050725 Firefox/1.0.6 (Ubuntu package 1.0.6) Mnenhy/0.7.1

When the mouse pass over the close tab button, a square appears instead of
change only the close tab button, it's hiding a little part of the line below.

Reproducible: Always

Steps to Reproduce:
1. Pass mouse over the close tab button

Actual Results:  
A clear square appears

Expected Results:  
Normally this square change only the close tab button not the button and little
around the control

Comment 1

[Cedric]

Attachment: Screenshot of the clear square

Comment 2

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050909 Firefox/1.6a1
ID:2005090916

Confirming. This is a Linux-only issue, and probably could be fixed pretty
easily with some CSS hacking.

Comment 3

[jeremy]

Attachment: This bugged me too...patch just removes padding from close.png

First patch--hope I did this right...I finally feel like I've contributed!

Comment 4

[Anders Conbere]

Attachment: Effects of Patch on Tab Height

Comment 5

[Anders Conbere]

It looks like the image paddings were being used to buffer up the tab bar, the result of this patch does work in that it removes the oversized background on hover, however the unintended result is that tabs are 1px smaller than they are usualy.

(or at least this is what I see when I impliment it through userChrome.css)

I've attached a screenshot to demonstrate what I'm talking about.

Comment 6

[Daniel C]

jeremy, you need to request review from someone. I'd suggest Asaf Romano <[e-mail]>. It would still be nice to get this in, regardless of the fact that the close-tab button is moving from the tab bar to the active tab in bug 308396.

Comment 7

[jeremy]

(In reply to comment #6)
> jeremy, you need to request review from someone. 

requested. And you're right about bug 308396 making this irrelevant, but it still feels good to have contributed--woo hoo!

Comment 8

[Adam Guthrie]

Comment on attachment 200840 [details] [diff] [review]
This bugged me too...patch just removes padding from close.png

If anyone is going to review this, it'd be kmgerich, but judging from the implications of this patch, and the fact that it would be invalidated by bug 308396, I really don't see it getting r+ed.

Comment 9

[Anders Conbere]

still an issue in RC2

Comment 10

[Reed Loden [:reed]]

*** Bug 297509 has been marked as a duplicate of this bug. ***

Comment 11

[Reed Loden [:reed]]

*** Bug 318830 has been marked as a duplicate of this bug. ***

Comment 12

[Reed Loden [:reed]]

*** Bug 318499 has been marked as a duplicate of this bug. ***

Comment 13

[Adam Guthrie]

Comment on attachment 200840 [details] [diff] [review]
This bugged me too...patch just removes padding from close.png

Requesting review on behalf of jeremy.

Comment 14

[Wolfgang Rosenauer [:wolfiR]]

The hovered icon still change the background color in a small area around itself.

Comment 15

[Robert Strong (they/them - no direct email)]

Comment on attachment 200840 [details] [diff] [review]
This bugged me too...patch just removes padding from close.png

(In reply to comment #14)
> The hovered icon still change the background color in a small area around
> itself.
Is this with the patch applied?

Adam, I'd prefer it if Kevin reviewed this change since it affects the theme and will hopefully know why it is this way in the first place.

Comment 16

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #15)
> > The hovered icon still change the background color in a small area around
> > itself.
> Is this with the patch applied?

yes, it is. But it's hard to see because it's really thin.

Comment 17

[jeremy]

Many thanks to Adam for resubmitting on my behalf; after using Mozilla (and Firefox nee Firebird nee Phoenix nee m/b) for years, I'm still a neophyte Moz hacker. It's the coolest feeling in the world to be able to contribute something even this miniscule! Ben has now landed his new ui on the trunk build; I've downloaded and will install on Win32 and Linux after posting this comment (OS X on Monday), and as such, I don't think this bug will be relevant any longer. I wanted to rework this patch (that thin border is still there), but will instead focus on the future, and will keep an eye out for another way I can be useful!

Comment 18

[Adam Guthrie]

"Fixed" by the patch in bug 308396.

Comment 19

[Kevin Brosnan]

*** Bug 325893 has been marked as a duplicate of this bug. ***

Comment 20

[:Gavin Sharp [email: [e-mail]]]

*** Bug 331944 has been marked as a duplicate of this bug. ***