307882 - Full headers shown by default after upgrade

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Thomas Watson Steen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

After upgrading to the new Thunderbird 1.5 beta 1 from the current stable
version (1.0.6) I found that all my e-mails and RSS items now show with full
headers - Both in the mail window and when I open them in a seperate window.

It is not a problem to switch headers back to "Normal" under "View -> Headers",
but it is not nice to look at the first time you open Thunderbird after the upgrade.

I do not know if this is an issue with a fresh install as well - only tried it
when upgrading.

Reproducible: Didn't try

Steps to Reproduce:

Comment 1

[Scott MacGregor]

Marcia saw this too and could then never reproduce it.

Did you have any extensions?

Comment 2

[Marcia Knous [:marcia]]

I need to keep an eye on this because I have seen it several times.  My normal
Tbird extensions are Enigmail, Foxytunes and infoRSS on my main machine.

Comment 3

[Scott MacGregor]

I know this bug is out there, I've seen it once but those of us who have seen it have never been able to find the combination that will trigger it reliably. 

This is probably gonna have to wait till 2.0.

We'll release note it though for users that do run into this.

Comment 4

[Scott MacGregor]

I just saw this again after doing the following:

1) using 1.5, installed enigmail
2) restarted, saw that engimail extension was working
3) uninstalled enigmail and restarted again

when thunderbird came up after step 3, i was in view all headers mode.

i wonder if enabling / removing the engimail extension is causing users to get stuck in view all headers mode. Or is that a red herring?

Thomas, do you use engimail?

Comment 5

[Scott MacGregor]

I don't know what the relationship is, but every time I uninstall or disable enigmail, I get left in view all headers mode. I think that's the trick that will cause you to see this. 

Comment 6

[Karsten Düsterloh]

> I don't know what the relationship is, but every time I uninstall or disable
> enigmail, I get left in view all headers mode.

Yes, extensions like Enigmail or Mnenhy need all headers passed from the backend. They probably could do (better) with a customized selection, but unfortunately that's not possible at the moment -> bug xxx (can't find it now) requests that.
(Also related: 236954)
 

Comment 7

[Patrick Brunschwig]

Fully agreed, it's definitely related to Enigmail (and/or Mnenhy). I just haven't found a safe method to override the default settings are re-set it when Enigmail is uninstalled. 

There is actually some code that sould reset "show_headers" at shutdown, but it doesn't work. 

Scott or Karsten, maybe you could help me:
I'm observing "xpcom-shutdown", and in the observer I set the value of show_headers back to what the user selected on the screen, but somehow this doesn't work properly. Do you know if xpcom-shutdown is the correct topic to observe, or is it too late (i.e. can I not change preferences anymore at this time)?

Comment 8

[Patrick Brunschwig]

Sorry forget my last comment, I just had another look into my code and found the bug!

I in the observer method finalized the object before resetting the preference. I'm about to release a new version of Enigmail, I'll include this in the release. Hence, I consider this bug as fixed for Thunderbird 1.5.

Comment 9

[Scott MacGregor]

that's great news. Thanks Patrick.