308754 - The preference binding events (syncfrompreference, synctopreference, change) are fired with wrong JS context

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Asaf Romano (gone)]

The preference binding events (syncfrompreference, synctopreference, change) are
fired with wrong JS context. An example of how can it break stuff is bug 297286
(a similar issue in the colorpicker).

Comment 1

[Karsten Düsterloh]

Attachment: call pseudo event in the context of the actual element

We stumbled upon this during SM pref panel migration.

Comment 2

[[e-mail]]

(In reply to comment #0)
> The preference binding events (syncfrompreference, synctopreference, change)
> are fired with wrong JS context.
As far as I can tell, preference change events have always use standard DOM dispatch with the correct context; for some reason colorpickers are weird because after DOM dispatch they then call their onchange attribute again?!

JFTR The preference-specific events don't have automatic handler attributes and therefore we don't use standard DOM dispatch there.

Comment 3

[Karsten Düsterloh]

Comment on attachment 295295 [details] [diff] [review]
call pseudo event in the context of the actual element

Here's hoping Asaf is more accessible on such issues he even filed himself. ;-)

Comment 4

[Asaf Romano (gone)]

Comment on attachment 295295 [details] [diff] [review]
call pseudo event in the context of the actual element

looks good.

Comment 5

[Karsten Düsterloh]

Comment on attachment 295295 [details] [diff] [review]
call pseudo event in the context of the actual element

Low risk; FF/TB/Minimo/Calendar are using global objects/functions to work around the bug and don't care for 'this'.

Comment 6

[Karsten Düsterloh]

Landed on trunk.