308812 - Go menu commands shouldn't have accesskeys

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P2)

Description

[Asaf Romano (gone)]

The commands in the Go menu ("Back", "Forward", "Home", "History") shouldn't
have accesskeys, they conflict with the global history items in this menu (see
also bug 261985).

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

(The dtd change is trunk-only)

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 196387 [details] [diff] [review]
patch

>-                <menuitem observes="viewHistorySidebar" accesskey="&historySidebarCmd.accesskey;" key="key_gotoHistory"/>
>+                <menuitem observes="viewHistorySidebar"
>+                          key="key_gotoHistory"/>
>               </menupopup>
>             </menu>

why are we making stuff multiple lines when its not necessary?	Unless there's
a whole ton of attrs, I don't like the one attribute per line bit, and that
doesn't apply here.

don't check in the .dtd changes on the branch and r=me

Comment 4

[Asaf Romano (gone)]

Checking in browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.64; previous revision: 1.63
done
Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <-- 
browser.dtd
new revision: 1.28; previous revision: 1.27
done

Comment 5

[Asaf Romano (gone)]

1.8 Branch:
Checking in browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.57.2.7; previous revision: 1.57.2.6
done

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I checked in the dtd change from this bug on the 1.8 branch since it wasn't checked in originally due to a l10n freeze.