309081 - Sync xpfe autocomplete attributes with toolkit ones (sync case)

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Frank Wein [:mcsmurf]]

There is the property named forceComplete in both toolkit/ and xpfe/
autocomplete to force autocomplete. But the toolkit version looks like this:
<property name="forceComplete"
          onset="this.setAttribute('forcecomplete', val); return val;"
          onget="return this.getAttribute('forcecomplete') == 'true';"/>

And the xpfe version like this:
<property name="forceComplete"
          onset="this.setAttribute('forceComplete', val); return val;
          onget="return this.getAttribute('forceComplete') == 'true';"/>

I think we should make work for developers and upcoming transitions easier, we
should just agree on one of the two versions here.

Comment 1

[Paul Tomlin]

toolkit/ attributes appear to be almost exclusively lower case, while properties are camelCase. If xpfe/ really is going away I'd suggest adopting the lowercase (toolkit) variant.

If I can get a direction on this I'll make a patch

From
http://lxr.mozilla.org/seamonkey/search?string=forceComplete

I see only a few references that would need changing
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/abEditListDialog.xul#94
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/abMailListDialog.xul#118
http://lxr.mozilla.org/seamonkey/source/mail/components/compose/content/messengercompose.xul#719
http://lxr.mozilla.org/seamonkey/source/xpfe/components/autocomplete/resources/content/autocomplete.xml#196
http://lxr.mozilla.org/seamonkey/source/xpfe/components/autocomplete/resources/content/autocomplete.xml#197
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/abListOverlay.xul#93
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/addressingWidgetOverlay.xul#80
http://lxr.mozilla.org/seamonkey/source/calendar/prototypes/wcap/sun-calendar-event-dialog-attendees.xml#76

Comment 2

[[e-mail]]

That would be helpful... there are a few other attributes which could do with being synchronised although I don't know how many of them Thunderbird use:

disableAutocomplete (property name mismatch!)
minResultsForPopup	ignoreBlurWhileSearching
showCommmentColumn	tabScrolling

Plus some attributes which toolkit doesn't have, but we might want to lowercase for consistency:

highlightNonMatches	autoFillAfterMatch	autoFill

Comment 3

[Mark Banner (:standard8)]

Attachment: Fix xpfe autocomplete and mailnews and mail

This is the patch that will do the changes to the lower case for all the attributes mentioned in comment 2. I'll request review on the mail/ changes once I know Neil's happy with the rest of them.

I'm doing a separate patch for Calendar, as that will need to work with the 1.8 branch as well as trunk.

Comment 4

[Mark Banner (:standard8)]

Attachment: Calendar Fix

Comment 5

[[e-mail]]

Comment on attachment 320869 [details] [diff] [review]
Fix xpfe autocomplete and mailnews and mail

>+                 defaultSearchEngine="true" tabscrolling="true"
Remind me to file a bug on fixing urlbarBindings.xml for consistency.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 320869 [details] [diff] [review]
Fix xpfe autocomplete and mailnews and mail

Looks fine, r=mkmelin
One nit: the change around _awSetAutoComplete - would be good to fix the overlong line

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 320870 [details] [diff] [review]
Calendar Fix

>+            <!-- Where attributes are repeated, this allows compatibility with
>+                 the Mozilla 1.8 branch -->
Could you please change "Mozilla 1.8 branch" to "MOZILLA_1_8_BRANCH", because we will presumably grep for that string when cleaning up the branch specifics in the future.

otherwise looks good; r=dbo

Please cross-commit to both branch and trunk.

Comment 8

[Mark Banner (:standard8)]

Calendar patch checked in on branch and trunk:

Checking in calendar/prototypes/wcap/sun-calendar-event-dialog-attendees.xml;
/cvsroot/mozilla/calendar/prototypes/wcap/sun-calendar-event-dialog-attendees.xml,v  <--  sun-calendar-event-dialog-attendees.xml
new revision: 1.42; previous revision: 1.41
Checking in calendar/prototypes/wcap/sun-calendar-event-dialog-attendees.xml;
/cvsroot/mozilla/calendar/prototypes/wcap/sun-calendar-event-dialog-attendees.xml,v  <--  sun-calendar-event-dialog-attendees.xml
new revision: 1.1.2.42; previous revision: 1.1.2.41

Main patch checked in on trunk:
Checking in mail/components/addrbook/content/abEditListDialog.xul;
/cvsroot/mozilla/mail/components/addrbook/content/abEditListDialog.xul,v  <--  abEditListDialog.xul
new revision: 1.10; previous revision: 1.9
done
Checking in mail/components/addrbook/content/abMailListDialog.xul;
/cvsroot/mozilla/mail/components/addrbook/content/abMailListDialog.xul,v  <--  abMailListDialog.xul
new revision: 1.10; previous revision: 1.9
done
Checking in mail/components/compose/content/addressingWidgetOverlay.js;
/cvsroot/mozilla/mail/components/compose/content/addressingWidgetOverlay.js,v  <--  addressingWidgetOverlay.js
new revision: 1.16; previous revision: 1.15
done
Checking in mail/components/compose/content/messengercompose.xul;
/cvsroot/mozilla/mail/components/compose/content/messengercompose.xul,v  <--  messengercompose.xul
new revision: 1.122; previous revision: 1.121
done
Checking in mailnews/addrbook/resources/content/abListOverlay.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abListOverlay.xul,v  <--  abListOverlay.xul
new revision: 1.24; previous revision: 1.23
done
Checking in mailnews/compose/resources/content/addressingWidgetOverlay.js;
/cvsroot/mozilla/mailnews/compose/resources/content/addressingWidgetOverlay.js,v  <--  addressingWidgetOverlay.js
new revision: 1.98; previous revision: 1.97
done
Checking in mailnews/compose/resources/content/addressingWidgetOverlay.xul;
/cvsroot/mozilla/mailnews/compose/resources/content/addressingWidgetOverlay.xul,v  <--  addressingWidgetOverlay.xul
new revision: 1.70; previous revision: 1.69
done
Checking in suite/browser/navigator.xul;
/cvsroot/mozilla/suite/browser/navigator.xul,v  <--  navigator.xul
new revision: 1.460; previous revision: 1.459
done
Checking in xpfe/components/autocomplete/resources/content/autocomplete.xml;
/cvsroot/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.162; previous revision: 1.161
done

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f4811ba7c780
Sync xpfe autocomplete attributes with toolkit ones (sync case). r=mkmelin,sr=Neil