360648 - [Meta] TB toolkit autocomplete migration

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Paul Tomlin]

This is a meta bug of issues relating to migration of autocomplete in TB to toolkit

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Nominating wanted-thunderbird3 to keep it on the radar.

Comment 2

[Mark Banner (:standard8)]

I think the general opinion is that shipping both xpfe and toolkit implementations isn't the way to go, instead, moving completely to toolkit's autocomplete.

I'm fairly sure Paul isn't doing much these days, so taking bug.

Comment 3

[David Ascher (:davida)]

Mark, do you think you can get this in by b1?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

What bug tracks changing mozilla/toolkit/content/xul.css to not have a special "ifdef MOZ_THUNDERBIRD" which results in "define AUTOCOMPLETE_OLD_STYLE", and modifies mozilla/toolkit/components/Makefile.in to add "autocomplete" to DIRS instead of just "autocomplete/public"?

Without this, we can't have the pretty sweet richlist implementation.  (Granted, it has a browser bias, but it does lots of neat stuff.)

Comment 5

[David :Bienvenu]

bug 360648 ?

Comment 6

[David :Bienvenu]

oh, sorry, heh. Mark would know.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #4)
> What bug tracks changing mozilla/toolkit/content/xul.css to not have a special
> "ifdef MOZ_THUNDERBIRD" which results in "define AUTOCOMPLETE_OLD_STYLE", and
> modifies mozilla/toolkit/components/Makefile.in to add "autocomplete" to DIRS
> instead of just "autocomplete/public"?

This one! I've just not posted a patch yet...

Comment 8

[Mark Banner (:standard8)]

Attachment: Remove old xpfe autocomplete address book search

This patch removes the old xpfe autocomplete based local address book search (which is currently kept for calendar integration).

Comment 9

[Mark Banner (:standard8)]

Attachment: Temporary removal of LDAP autcomplete (not for check in)

This patch removes the ldap autocomplete so that we can build with just toolkit interfaces.

Comment 10

[Mark Banner (:standard8)]

Attachment: Switches TB to toolkit autocomplete (mozilla-central patch)

This patch actually switches TB to use toolkit autocomplete - it is a mozilla-central patch.

Comment 11

[David Ascher (:davida)]

Switching for b1 flags to target milestones, to avoid flag churn.

Comment 12

[Mark Banner (:standard8)]

3.0b1 flag is going away in favour of 3.0 flag and milestone combination.

Comment 13

[Mark Banner (:standard8)]

Attachment: [checked in] Enable building of toolkit autocomplete for Thunderbird (not enabling the UI!)

TB would like to enable building of the toolkit autocomplete code (not just the interfaces) ready for beta 1.

This is a simple toolkit makefile patch - the first block just joins up two lots of DIRS = statements that don't need to be separate. The second block enables building of all of autocomplete for Thunderbird.

Although this doesn't enable the bindings, this does do enough for TB devs to play around with things in extensions and hopefully show them off in TB 3 beta 1.

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 339844 [details] [diff] [review]
[checked in] Enable building of toolkit autocomplete for Thunderbird (not enabling the UI!)


> 
> ifdef MOZ_XUL
>-DIRS += \
>-	autocomplete \
>-	satchel \
>-	$(NULL)
>+DIRS += satchel
> endif # MOZ_XUL

Seems like it would be more readable if you just coalesced this into the MOZ_XUL block above it.

r=dmose from the "Thunderbird changes" point of view

Comment 15

[Mark Banner (:standard8)]

(In reply to comment #14)
> (From update of attachment 339844 [details] [diff] [review])
> 
> > 
> > ifdef MOZ_XUL
> >-DIRS += \
> >-	autocomplete \
> >-	satchel \
> >-	$(NULL)
> >+DIRS += satchel
> > endif # MOZ_XUL
> 
> Seems like it would be more readable if you just coalesced this into the
> MOZ_XUL block above it.

Except that there are various other directories that are ifndef MOZ_THUNDERBIRD, so it doesn't really clean much up, and would only add an extra MOZ_THUNDERBIRD instead of a MOZ_XUL.

Comment 16

[Mark Banner (:standard8)]

This isn't making beta 1... moving out.

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 339844 [details] [diff] [review]
[checked in] Enable building of toolkit autocomplete for Thunderbird (not enabling the UI!)

This was checked in ages ago (September): http://hg.mozilla.org/mozilla-central/rev/0e49b86be866

Comment 18

[Mark Banner (:standard8)]

This doesn't block the current features we want to get into Thunderbird 3, hence no longer needs to block TB 3. Still very much wanted.

Reassigning to default owner as I haven't got time to work on this at the moment. See status whiteboard for what needs fixing before this can be fixed. Once they are fixed then we'll need some build config changes in mozilla-central to build toolkit rather than xpfe autocomplete and include the appropriate style sheets.

Comment 19

[Alexey Gladkov]

Attachment: Convert autocomplete to frozen/external linkages

Port the autocomplete module to use frozen linkages.

Comment 20

[Alexey Gladkov]

Ooops ... I think I'm wrong with this patch. Sorry.

Comment 21

[Mark Banner (:standard8)]

(In reply to comment #19)
> Created an attachment (id=369584) [details]
> Convert autocomplete to frozen/external linkages

(In reply to comment #20)
> Ooops ... I think I'm wrong with this patch. Sorry.

Well if you want to move xpfe autocomplete to frozen linkage you can do so in a separate bug.

However we'd really like to just drop xpfe autocomplete completely and switch to toolkit autocomplete (so we can further align ourselves with core) - which is what this bug (and bug 452232) are about.

Comment 22

[Gary Oberbrunner]

Does this bug still depend on bug 452232?  All the other dependencies are now resolved.  Does not having LDAP autocomplete in toolkit prevent switching TB to toolkit autocomplete?

Comment 23

[Mark Banner (:standard8)]

(In reply to comment #22)
> Does this bug still depend on bug 452232?  All the other dependencies are now
> resolved.  Does not having LDAP autocomplete in toolkit prevent switching TB to
> toolkit autocomplete?

Yes it does depend on bug 452232 - until LDAP autocomplete is switched over to the toolkit interfaces, we can't do the full switch of TB to the toolkit autocomplete. Note that xpfe supports the toolkit interfaces so that you can still use xpfe autocomplete in the same way as toolkit.

Comment 24

[Magnus Melin [:mkmelin]]

Thunderbird is now fully migrated, yay!