Closed Bug 309453 Opened 19 years ago Closed 19 years ago

Bookmarks drag and drop causes temporary freeze

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Product:
Core
Component:
DOM: Copy & Paste and Drag & Drop
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED DUPLICATE of bug 305970

People

(Reporter: blueser, Unassigned)

Details

(Keywords: qawanted, regression) 

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Dragging a link from the location bar to the bookmarks panel on the left causes
a temporary freeze simply by passing over a directory; the panel goes "blank"
and firefox momentarily freezes. Waiting 2-3s restores normal operation, but if
 the mouse button is released during this period of time, chances are that the
link was stored at the wrong place.

Also, dragging links to folders on the personal toolbar folder sometimes only
"flicks" the folder under the mouse pointer and doesn't open the submenu.

Reproducible: Always

Steps to Reproduce:
1. drag a link from the location toolbar
2. pass it over any folder on the toolbar panel on the left
3.

Actual Results:  
Browser freezes momentarily.

Expected Results:  
Only expand a folder after the mouse was above it for "sometime" (~1s maybe? I
don't really know what numbers to suggest here, all I know is that it seems
there's no timeout at all). Also, the "freezing" thing obviously sucks.
This is a pretty serious issue. This has been observed with dragging other
things, too, such as items from the customize toolbar dialog, and even with
tabs. Also seems to be a recent regression.
Severity: normal → critical
Status: UNCONFIRMED → NEW
Component: Bookmarks → Drag and Drop
Ever confirmed: true
Flags: blocking1.8b5?
Keywords: qawanted, regression
Product: Firefox → Core
QA Contact: bookmarks
Version: unspecified → Trunk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050921
Firefox/1.6a1 ID:2005092123

Related to Bug 307260 ?
Although I've never had such problems.
(In reply to comment #2)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050921
> Firefox/1.6a1 ID:2005092123
> 
> Related to Bug 307260 ?

Yes, it could be. Also, I believe that bug 307260's description is more
accurate, I can't reproduce the problem all the time as I described on my
original post. I'll do additional tests, but it could be that it indeed happens
once per session, and most likely for the 1st Firefox window you open on this
session (I just tried it on a second window while I was writing this reply and
could not reproduce the problem).

> Although I've never had such problems.

Mmmh... looks like this bug won't go down easily =/
when did this regress? can we get it narrowed down to a single day so we can
look over checkins and find what broke this?
I'm almost positive this is due to a recent upgrade to GTK. I was running Fedora
Core 4 when I witnessed this and I know that there was an upgrade to GTK via yum
around the time frame that this started occuring.

The reason I'm thinking that this is GTK is because I witnessed this while
dragging tabs, and while dragging an item from the customize toolbars dialog.
Something this widespread couldn't be caused by one check-in... at least I don't
think it could. 

If we could get some testing with the current GTK version and the version
released before that and see if the GTK updgrade is the culprit here that'd be
great. Clearing blocking flag for now.
Flags: blocking1.8b5?
(In reply to comment #5)
> I'm almost positive this is due to a recent upgrade to GTK. I was running Fedora
> Core 4 when I witnessed this and I know that there was an upgrade to GTK via yum
> around the time frame that this started occuring.
> 
> The reason I'm thinking that this is GTK is because I witnessed this while
> dragging tabs, and while dragging an item from the customize toolbars dialog.
> Something this widespread couldn't be caused by one check-in... at least I don't
> think it could. 
> 
> If we could get some testing with the current GTK version and the version
> released before that and see if the GTK updgrade is the culprit here that'd be
> great. Clearing blocking flag for now.

Just for the record, I am using FC4, so it could indeed be related. GNOME
version is 2.6.10.
I can reproduce this problem too.
My emvironment is Debian GNU/Linux Unstable,
GTK+ version is 2.6.10-1.
*** Bug 313386 has been marked as a duplicate of this bug. ***
Another Japanese user's bug report.
(http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=4679)

His environment is
Ubuntu-ja 5.10
GTK 2.8.6
static build
(In reply to comment #9)
> Another Japanese user's bug report.
> (http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=4679)
> 
> His environment is
> Ubuntu-ja 5.10
> GTK 2.8.6
> static build
> 

I am on Ubuntu as well. It maybe worthy to note that when the freeze occurs, the mouse cursor never returns from the dragging state (well, I think it actually did return to normal state ONCE), so I had to go to console to kill firefox.

(In reply to comment #10)

Forgot to mention that's for bug 313386
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051022 Firefox/1.6a1

I can reproduce this consistently with my current profile with the following extensions installed:

DOMi
SessionSaver
DictionarySearch
Nightly Tester Tools and 
TinyURL Creator.

*But* I can't seem to reproduce this in safe mode or with a clean profile. Do any of you guys have one of these extensions installed? I have a feeling it might be SessionSaver that's breaking stuff.


(In reply to comment #10)
> (In reply to comment #9)
> > Another Japanese user's bug report.
> > (http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=4679)
> > 
> > His environment is
> > Ubuntu-ja 5.10
> > GTK 2.8.6
> > static build
> > 
> 
> I am on Ubuntu as well. It maybe worthy to note that when the freeze occurs,
> the mouse cursor never returns from the dragging state (well, I think it
> actually did return to normal state ONCE), so I had to go to console to kill
> firefox.

Well, I seem to be able to work around this bug everytime it occurs by keeping mouse button pressed long enough (~5-10s); usually after this amount of time, Firefox resumes "normal behavior". YMMV.
(In reply to comment #12)
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051022 Firefox/1.6a1
> 
> I can reproduce this consistently with my current profile with the following
> extensions installed:
> 
> DOMi
> SessionSaver
> DictionarySearch
> Nightly Tester Tools and 
> TinyURL Creator.
> 
> *But* I can't seem to reproduce this in safe mode or with a clean profile. Do
> any of you guys have one of these extensions installed? I have a feeling it
> might be SessionSaver that's breaking stuff.

Haven't tested it with a clean profile, but my extensions are completely different from yours (TabBrowser, AdBlock, GMail, Flashgot) and the bug still happens nonetheless.
There's another weird behavior that might be related to this bug: if I have a folder on my Personal Toolbar and I click it, first menu level opens just fine. However, placing the mouse over any submenu causes the menu selection bar to flicks at a high frequency, and the submenu doesn't appear. Clicking on the submenu entry pops up the corresponding submenu as expected -- _but_ once its closed, weird behavior resumes.

This happens on almost every submenu for me. Oddly enough, it doesn't happen for _some_ submenus (haven't figured out yet what triggers the problem).

Any of you guys also experiences this? If so, I will file another bug report about it.
(In reply to comment #15)
> There's another weird behavior that might be related to this bug: if I have a
> folder on my Personal Toolbar and I click it, first menu level opens just fine.
> However, placing the mouse over any submenu causes the menu selection bar to
> flicks at a high frequency, and the submenu doesn't appear. Clicking on the
> submenu entry pops up the corresponding submenu as expected -- _but_ once its
> closed, weird behavior resumes.

That's bug 306426. Andre, could you please test this in safe mode and/or a new profile. We need to figure out if this problem is extension-related.

I can't reproduce with new profile.
But I don't think this is extension-related problem
because I don't use any extension.
(In reply to comment #16)
> (In reply to comment #15)
> > There's another weird behavior that might be related to this bug: if I have a
> > folder on my Personal Toolbar and I click it, first menu level opens just fine.
> > However, placing the mouse over any submenu causes the menu selection bar to
> > flicks at a high frequency, and the submenu doesn't appear. Clicking on the
> > submenu entry pops up the corresponding submenu as expected -- _but_ once its
> > closed, weird behavior resumes.
> 
> That's bug 306426. Andre, could you please test this in safe mode and/or a new
> profile. We need to figure out if this problem is extension-related.

Hi Adam,

I just tried it here at home with a clean profile (no extensions, no themes etc.) and it _seems_ the bug indeed doesn't show up. I will do some more testing at work later (where I experience the bug very often) and will put back here the results.

Thks for the reference to bug #306426.
I just tested it here at work, and, indeed, the problem doesn't seem to be reproducible. Again, I did not test it thoroughly, so I can't really guarantee the problem is extension-related, but it seems to be a solid lead. (I created a couple of folders with subfolders, and dragged some links around).

BTW: starting Firefox 1.5b2 with a brand new profile from the command-line made these appear on the console:

*** upgradeExtensionChrome: failed for extension talkback@mozilla.org - why not convert to the new chrome.manifest format while you're at it? Failure exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///usr/local/firefox/components/nsExtensionManager.js :: anonymous :: line 1466"  data: no]
*** upgradeExtensionChrome: failed for extension talkback@mozilla.org - why not convert to the new chrome.manifest format while you're at it? Failure exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///usr/local/firefox/components/nsExtensionManager.js :: anonymous :: line 1466"  data: no]
*** safeInstallOperation: failed to clean up item location after its contents were properly backed up. Failed to clean up: /usr/local/firefox/extensions/talkback@mozilla.org ... rolling back file moves and aborting installation.
*** _finalizeUninstall: failed to remove directory for item: talkback@mozilla.org at Install Location: app-global, rolling back uninstall
*** ExtensionManager:_finishOperations - failure, catching exception - lineno: 3226 - file: file:///usr/local/firefox/components/nsExtensionManager.js - TypeError: installLocation has no properties

IIRC this happens to every new profile I use with 1.5, and it happens just once. I guess this is harmless but, since we're in the dark here, I thought it was worth mentioning.
I think bug 312654 is related to this 
because comment 13 workaround is effective for that bug too.
Some temporary freezes while drag'n'droping links also appear an my Firefox 1.5-Nightly-Build.

Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8) Gecko/20051107 Firefox/1.5 ID:2005110704

I think this should be fixed before Firefox 1.5-release.


Not sure about bookmarks, but I think I'm having problems with casual drag-n-drop calls since I've moved to Linux (Debian, stable then testing).
Firefox 1.0.x, then Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
(In reply to comment #22)
> Not sure about bookmarks, but I think I'm having problems with casual
> drag-n-drop calls since I've moved to Linux (Debian, stable then testing).
> Firefox 1.0.x, then Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8)
> Gecko/20051111 Firefox/1.5
> 

Like Bug 313386?

*** This bug has been marked as a duplicate of 305970 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.