310305 - Message Filters Delete Text

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[John Liebson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050927 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050927 Thunderbird/1.4 - Build ID: 2005092708

I believe this started with the build I put in "Build Identify": Nearly all
messages moved by TB filters have their text deleted. It happens with existing
filters and with newly-created ones.

Reproducible: Always

Steps to Reproduce:
1. Create a filter
2. Send yourself a message
3. Retrieve message

Actual Results:  
Filter moved the message, which then had no text.

Expected Results:  
Moved message complete with text.

There are reports of this on MozillaZine in the TB Builds forum.

Comment 1

[John Liebson]

I just disabled all filters, sent myself a message, enabled one filter, ran it
on the message I'd sent myself. At that point, things got very confused:

1. The filter log showed that the message had been moved, but it was still where
it was received, not having been moved.

2. I started to write this addition to my bug report, but returned to the TB
main mail window, where I noticed that the folder that should have received the
message that the filter was to move now indicated there were messages in it.

2a. I moved to that folder, where I found my now filter-moved message, but I
also found a blank message.

2b. This blank message is quite strange: On screen, it shows a date of
31/12/1969, but the header makes it clear that it is a copy of the message that
the filter eventually moved. I know that, because the header of the blank
message and the filter-moved one are identical as to sender and time, 7:19. (I
had deleted the .msf file for this folder a short while before this action took
place.)

2c. Note that the text of the filter-moved message is intact; I've moved another
message via filter after receiving it (i.e., the filter was inactive when
on-line) and the text was preserved.

Comment 2

[David :Bienvenu]

Is that a 1.8/1.5 branch build? I wonder if the duplicate detection patch landed
awkwardly? I'll try a branch build...

Comment 3

[John Liebson]

Yes, it is the daily update to the original 1.5 Beta 1 release.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

this happens when quarantining messages - my second patch in duplicate deletion
code when combined with quarantinging messages caused this.

Comment 5

[David :Bienvenu]

Comment on attachment 197739 [details] [diff] [review]
proposed fix

this will need to go on the branch as well. This patch backs out part of the
aforementioned change, which was not needed, and it turns out, harmful :-(

Comment 6

[Worcester12345]

I had some unfiltered messages coming up blank as well. Also, there were some
which should have been filtered, but were not, and some were blank and some were
not. Very strange stuff. How can I help?

Comment 7

[David :Bienvenu]

again, try tomorrow's build.

Comment 8

[Worcester12345]

Junk mail filtering also seems affected. I had all filters turned off but forgot
to turn off junk filtering and another one (thankfully really junk) got wiped
clean of its message body.

Comment 9

[Worcester12345]

...and just now another junk one stayed in the inbox but marked as junk without
me changing any settings. Hope that helps somehow.