310545 - "Allow web sites to install software" has been changed to "Warn me when web sites try to install extensions or themes"

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

See bug 288054 and
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/locales/en-US/chrome/browser/preferences&command=DIFF_FRAMESET&file=content.dtd&rev1=1.5&rev2=1.6&root=/cvsroot

Currently trunk only, but marked as blocking1.8b5+ and approval1.8b5+, so we're
going to need this for Firefox 1.5.

Comment 1

[Steffen Wilberg]

Branch checkin, including renaming the "Allowed Sites" button to "Exceptions":
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/locales/en-US/chrome/browser/preferences&command=DIFF_FRAMESET&file=content.dtd&rev1=1.4&rev2=1.4.2.1&root=/cvsroot

Comment 2

[Steffen Wilberg]

The checkbox now controls the "xpinstall.whitelist.required" instead of the
"xpinstall.enabled" pref. With the whitelist enabled, you get the yellow info
bar. With the whitelist disabled, sites can annoy you with unwanted install
prompts, and gives malicious sites an opportunity to badger you into clicking OK
(from bug 288054 comment 54).

Comment 3

[Steffen Wilberg]

Attachment: patch

Note that the warning (the info bar) is not displayed for themes, see bug
288054 comment 68.

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 198226 [details] [diff] [review]
patch

r=me with the removal of the comma after "tries to install an extension" (it's
a comma splice otherwise).

Comment 5

[Jeff Walden (gone starting June 8)]

A little birdie who shall go unnamed but whose IRC nick starts with "Ma" and
ends with "no" informs me that this bit of UI will change after beta to
something else.  The little birdie places the blame for this on a person who
shall go nameless but whose IRC nick starts with "dv" and ends with "editz".

Consequently, it looks like this probably should wait on checkin at least until
we're certain they're done messing with it, and if they actually do manage whack
at it a few more times we might need an entirely new patch.

Aren't random UI changes fun?

Comment 6

[Steffen Wilberg]

I checked this in since the discussed changes in bug 310737 are likely to keep
the UI for the xpinstall.whitelist.required pref so we need most of this anyway,
because this is correct right now, and because the tree is about to close for 1.8b5.

Checking in mozilla/browser/locales/en-US/chrome/help/prefs.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/prefs.xhtml,v  <--  prefs.xhtml
new revision: 1.38; previous revision: 1.37
done
Checking in mozilla/browser/locales/en-US/chrome/help/prefs.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/prefs.xhtml,v  <--  prefs.xhtml
new revision: 1.34.2.4; previous revision: 1.34.2.3
done

Comment 7

[Steffen Wilberg]

Nothing to change from bug 310737.