310673 - Add continuous validation test capability

Status: NEW

(Bugzilla :: Testing Suite, enhancement, P3)

Description

[Joel Peshkin]

This needs a bit of cleanup, but it is possible to wrap the template toolkit in
a wrapper that calls an html validator.  

We should definitely do this on certain installs on landfill.

There is a validator at http://www.htmlhelp.com/tools/validator/ that is easy to
build and install.

Comment 1

[Joel Peshkin]

Attachment: Crude patch validating html continuously

Comment 2

[Joel Peshkin]

TODO:
   1) Move valudation function to Template.pm (no reason to involve Util.pm)
   2) Make location of validator executable configurable (localconfig, param, or
COnfig.pm ??)
   3) Add the URL used to trigger the failing template to the logged information.
   4) Save an exerpt of the HTML in the area of the first failure.
   5) Disable the WRAPPER function altogether if validation is not in use.

Then, this is actually non-invasive enough that it could land.

Comment 3

[Joel Peshkin]

Attachment: Non-invasive patch

Comment 4

[Joel Peshkin]

You can try this on landfill using "/opt/validator/bin/validate" or
"/opt/validator/bin/validate --verbose" as the value for the "validator" parameter.

Comment 5

[Frédéric Buclin]

Comment on attachment 198413 [details] [diff] [review]
Non-invasive patch

defparams.pl no longer exists

Comment 6

[Frédéric Buclin]

The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.

Comment 7

[Frédéric Buclin]

see bug 148487

Comment 8

[Frédéric Buclin]

Note that I now use the 'HTML Validator' extension of Firefox to track HTML errors. Maybe that's enough as you cannot use runtests.pl here anyway.

Comment 9

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".