310751 - Tabular reports query page fails w3 validation

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

search/search-report-table.html.tmpl:(/home/bugzilla/tip/query.cgi)
Checking with HTML 4.01 Transitional document type...
*** Errors: ***
Error at line 136, character 45:  there is no attribute "HEIGHT" for this
        element (in this HTML version)

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

add FILTER replace (' ' , '_') to ID attributes
remove height attribute from table
remove detached <p>

Comment 2

[Frédéric Buclin]

Comment on attachment 233210 [details] [diff] [review]
patch for tip

>Index: template/en/default/search/form.html.tmpl

>+        <input type="submit" id="[% button_name FILTER replace (' ' , '_') FILTER html %]"
>                value="[% button_name FILTER html %]">

Nit: I prefer: button_name.replace(' ', '_') FILTER html



>Index: template/en/default/search/search-report-table.html.tmpl

>     <td width="150" height="150">
>-      <table border="1" width="100%" height="100%">
>+      <table border="1" width="100%">
>         <tr>
>           <td align="center" valign="middle">

To not alter the UI, you have to move height="150" in the <td> containing valign="middle".


>+<input type="submit" id="[% button_name FILTER replace (' ' , '_') FILTER html %]"

Same comment as above.

Else your patch is correct. My HTML validator is happy with it. :)

Comment 3

[victory <[e-mail]>]

Attachment: patch for tip v2

take #2

Comment 4

[Frédéric Buclin]

Comment on attachment 236595 [details] [diff] [review]
patch for tip v2

>Index: template/en/default/search/search-report-table.html.tmpl

>     <td width="150" height="150">

Nit: this height="150" is now useless.

Comment 5

[Frédéric Buclin]

Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v  <--  form.html.tmpl
new revision: 1.42; previous revision: 1.41
done
Checking in template/en/default/search/search-report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-table.html.tmpl,v  <--  search-report-table.html.tmpl
new revision: 1.11; previous revision: 1.10
done