Tabular reports query page fails w3 validation

RESOLVED FIXED in Bugzilla 3.0

Status

()

defect
--
minor
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: bugreport, Assigned: spam)

Tracking

2.21
Bugzilla 3.0
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

14 years ago
search/search-report-table.html.tmpl:(/home/bugzilla/tip/query.cgi)
Checking with HTML 4.01 Transitional document type...
*** Errors: ***
Error at line 136, character 45:  there is no attribute "HEIGHT" for this
        element (in this HTML version)
Posted patch patch for tip (obsolete) — Splinter Review
add FILTER replace (' ' , '_') to ID attributes
remove height attribute from table
remove detached <p>
Attachment #233210 - Flags: review?

Comment 2

13 years ago
Comment on attachment 233210 [details] [diff] [review]
patch for tip

>Index: template/en/default/search/form.html.tmpl

>+        <input type="submit" id="[% button_name FILTER replace (' ' , '_') FILTER html %]"
>                value="[% button_name FILTER html %]">

Nit: I prefer: button_name.replace(' ', '_') FILTER html



>Index: template/en/default/search/search-report-table.html.tmpl

>     <td width="150" height="150">
>-      <table border="1" width="100%" height="100%">
>+      <table border="1" width="100%">
>         <tr>
>           <td align="center" valign="middle">

To not alter the UI, you have to move height="150" in the <td> containing valign="middle".


>+<input type="submit" id="[% button_name FILTER replace (' ' , '_') FILTER html %]"

Same comment as above.

Else your patch is correct. My HTML validator is happy with it. :)
Attachment #233210 - Flags: review? → review-

Updated

13 years ago
Assignee: myk → bmo
Target Milestone: --- → Bugzilla 3.0
take #2
Attachment #233210 - Attachment is obsolete: true
Attachment #236595 - Flags: review?

Comment 4

13 years ago
Comment on attachment 236595 [details] [diff] [review]
patch for tip v2

>Index: template/en/default/search/search-report-table.html.tmpl

>     <td width="150" height="150">

Nit: this height="150" is now useless.
Attachment #236595 - Flags: review? → review+

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+

Comment 5

13 years ago
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v  <--  form.html.tmpl
new revision: 1.42; previous revision: 1.41
done
Checking in template/en/default/search/search-report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-table.html.tmpl,v  <--  search-report-table.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.