310753 - editflagtypes page fails w3 validation

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

admin/flag-type/list.html.tmpl:(/home/bugzilla/tip/editflagtypes.cgi)
Checking with HTML 4.01 Transitional document type...
*** Errors: ***
Error at line 123, character 12:  ID "FLAG_TYPES" already defined
        Line 96, character 12:  ID "FLAG_TYPES" first defined here

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

use flag_types_bugs and flag_types_attachments instead of flag_types.

Comment 2

[Frédéric Buclin]

Comment on attachment 233206 [details] [diff] [review]
patch for tip


>-  <table id="flag_types" cellspacing="0" cellpadding="4" border="1">
>+  <table id="flag_types_[% css_id %]" cellspacing="0" cellpadding="4" border="1">

I'm pretty sure 008filter.t will complain that css_id is unfiltered.

Comment 3

[victory <[e-mail]>]

Attachment: patch for tip v2

FILTER url_quote'ed

Comment 4

[Frédéric Buclin]

Comment on attachment 233225 [details] [diff] [review]
patch for tip v2

>+  <table id="flag_types_[% css_id FILTER url_quote %]" cellspacing="0" cellpadding="4" border="1">

No, it must be html'ed filtered. url_quote must only be used within URLs. Also, css_id is not a good name IMO, because this has nothing to do with CSS. Why not "type" (if not already in use) or "type_id"?

Comment 5

[victory <[e-mail]>]

Attachment: patch for tip v3

OK, fixed

Comment 6

[Frédéric Buclin]

Comment on attachment 233226 [details] [diff] [review]
patch for tip v3

r=LpSolit

Comment 7

[Frédéric Buclin]

Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.15; previous revision: 1.14
done