editflagtypes page fails w3 validation

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
User Interface
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Joel Peshkin, Assigned: victory <never@receive.bug.mails.i.hate.spammer>)

Tracking

2.21
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
admin/flag-type/list.html.tmpl:(/home/bugzilla/tip/editflagtypes.cgi)
Checking with HTML 4.01 Transitional document type...
*** Errors: ***
Error at line 123, character 12:  ID "FLAG_TYPES" already defined
        Line 96, character 12:  ID "FLAG_TYPES" first defined here
Created attachment 233206 [details] [diff] [review]
patch for tip

use flag_types_bugs and flag_types_attachments instead of flag_types.
Attachment #233206 - Flags: review?

Comment 2

12 years ago
Comment on attachment 233206 [details] [diff] [review]
patch for tip


>-  <table id="flag_types" cellspacing="0" cellpadding="4" border="1">
>+  <table id="flag_types_[% css_id %]" cellspacing="0" cellpadding="4" border="1">

I'm pretty sure 008filter.t will complain that css_id is unfiltered.
Attachment #233206 - Flags: review? → review-
Created attachment 233225 [details] [diff] [review]
patch for tip v2

FILTER url_quote'ed
Attachment #233206 - Attachment is obsolete: true
Attachment #233225 - Flags: review?

Comment 4

12 years ago
Comment on attachment 233225 [details] [diff] [review]
patch for tip v2

>+  <table id="flag_types_[% css_id FILTER url_quote %]" cellspacing="0" cellpadding="4" border="1">

No, it must be html'ed filtered. url_quote must only be used within URLs. Also, css_id is not a good name IMO, because this has nothing to do with CSS. Why not "type" (if not already in use) or "type_id"?
Attachment #233225 - Flags: review? → review-
Created attachment 233226 [details] [diff] [review]
patch for tip v3

OK, fixed
Attachment #233225 - Attachment is obsolete: true
Attachment #233226 - Flags: review?

Comment 6

12 years ago
Comment on attachment 233226 [details] [diff] [review]
patch for tip v3

r=LpSolit
Attachment #233226 - Flags: review? → review+

Updated

12 years ago
Assignee: myk → bmo
Flags: approval?
Target Milestone: --- → Bugzilla 3.0
Flags: approval? → approval+

Comment 7

12 years ago
Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.