311015 - safe mode: add support for disabling all extensions

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Mike Connor [:mconnor]]

Spun off so I can resolve bug 304403.

Need a new EM method to disable all addons of all types, excepting app disabled
and app managed addons.
Unhide checkbox, and make it trigger this method.

Not going to happen for 1.5

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since it won't be supported for 1.5 we should hide this option during the first
safe-mode startup for 1.8. Further showings of that window don't include it.

Comment 2

[Mike Connor [:mconnor]]

are you sure that its ever visible?  its hidden="true" so I don't see how its
showing up at all.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> are you sure that its ever visible?  its hidden="true" so I don't see how its
> showing up at all.

Yes, I saw that checkbox with my development profile which is still a bit older.
After a second restart it is not visible anymore. Also fresh profiles don't show
that checkbox. It seems that it was a conflict with older data in my profile. So
don't worry about.

Comment 4

[Robert Strong (they/them - no direct email)]

Code to disable all extensions, locales, and plugins:

const nsIUpdateItem = Components.interfaces.nsIUpdateItem;
var em = Components.classes["@mozilla.org/extensions/manager;1"]
                   .getService(Components.interfaces.nsIExtensionManager);
var type = nsIUpdateItem.TYPE_EXTENSION + nsIUpdateItem.TYPE_LOCALE + nsIUpdateItem.TYPE_PLUGIN;
var items = em.getItemList(type, { });
for (var i = 0; i < items.length; ++i)
  em.disableItem(items[i].id);

Comment 5

[Robert Strong (they/them - no direct email)]

btw: when I stated extensions, locales, and plugins I am referring to Extension Manager managed items of these types.

Comment 6

[Robert Strong (they/them - no direct email)]

The concerns regarding Extension Manager managed locales and plugins are resolved now on the trunk and should be resolved on the branch before this would be ready for checkin.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I'm not sure that this does the right thing with locale packs and plugins, but this seems to work for extensions and the theme.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 223581 [details] [diff] [review]
patch

>Index: browser/base/content/safeMode.js
>===================================================================

>+  // Select the default theme
>+  const themePref = "general.skins.selectedSkin";
>+  var prefB = Components.classes["@mozilla.org/preferences-service;1"]
>+                        .getService(Components.interfaces.nsIPrefBranch);
>+  prefB.setCharPref(themePref, "classic/1.0");
>+}

Should use clearUserPref here.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch with Mano's suggestion

(In reply to comment #8)
> Should use clearUserPref here.

Indeed, thanks!

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 223583 [details] [diff] [review]
patch with Mano's suggestion

Looks fine and this does disable locales packs and plugins.

btw (not part of this bug): the ui for safe mode is a bit misleading. When you select the checkboxes for an operation and click continue in safe mode the operations are not performed.

Also, the try catch around the different operations performed seems to be a bit much. If any of these are prone to throwing it will prevent subsequent operations from being performed. Seems like either it should be removed or if some parts are prone to throwing then they should be addresses specifically.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 223583 [details] [diff] [review]
patch with Mano's suggestion

hmm, that try/catch is pretty bloaty.  Gavin, can you file a followup and break those into independent try/catch blocks?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/safeMode.dtd 	1.2
mozilla/browser/base/content/safeMode.js 	1.6
mozilla/browser/base/content/safeMode.xul 	1.5

Comment 13

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/safeMode.dtd 	1.1.2.1
mozilla/browser/base/content/safeMode.xul 	1.1.2.4
mozilla/browser/base/content/safeMode.js 	1.1.2.4