String offset problem in the XForms XPath engine

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
10 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

752 bytes, application/xhtml+xml
Details
5.41 KB, patch
smaug
: review+
Doron Rosenberg (IBM)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
*sigh* wrong and stupid fix in bug 277929 makes a lot of XPath functions fail.
(Assignee)

Comment 1

12 years ago
Created attachment 198429 [details]
Testcase

This testcase uses following-sibling:: and fails
(Assignee)

Comment 2

12 years ago
Created attachment 198430 [details] [diff] [review]
Patch

Fixes the offset-error, instead of the original "insert a space before name"
*sigh*. (also removes the unnecessary else statements...)

I also added a warning so it's easier to detect that the scanner returns an
error token.
(Assignee)

Updated

12 years ago
Attachment #198430 - Flags: review?(smaug)

Updated

12 years ago
Attachment #198430 - Flags: review?(smaug)
Attachment #198430 - Flags: review?(doronr)
Attachment #198430 - Flags: review+

Updated

12 years ago
Attachment #198430 - Flags: review?(doronr) → review+
(Assignee)

Comment 3

12 years ago
This was checked in to trunk quite a while ago
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch

Comment 4

11 years ago
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED

Comment 5

11 years ago
verified fixed in MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.