311261 - Threaded mail view in Virtual Folders is not possible

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Ian Neal]

All sorting options "Threaded" "Unthreaded" "Grouped by Sort" are greyed out for
Virtual Folders.
Selecting the sort order by clicking the column heads in the message pane works
for other columns but not for the Thread column.

Suite part for bug 263180

Comment 1

[Ian Neal]

Attachment: Simple patch v0.1

This patch:
* Adds suite front end to have threaded mail view in virtual folders

Comment 2

[[e-mail]]

Argh, I had a review comment for this, but it must have got lost in a crash :-(

Comment 3

[[e-mail]]

Comment on attachment 198631 [details] [diff] [review]
Simple patch v0.1

>                   var dbFolderInfo = msgDatabase.dBFolderInfo;
>                   sortType = dbFolderInfo.sortType;
>                   sortOrder = dbFolderInfo.sortOrder;
>+                  viewFlags = dbFolderInfo.viewFlags;
>                   if (folderFlags & MSG_FOLDER_FLAG_VIRTUAL)
>                   {
>                     viewType = nsMsgViewType.eShowQuickSearchResults;
The else clause of this if sets viewFlags and viewType and clears
gSearchSession. That assignment to viewFlags is now superfluous but I think it
would be more obvious if you simply moved those three lines here before the if.
You could then also get rid of the other line that clears gSearchSession.

Comment 4

[Ian Neal]

Attachment: Tweaked simple patch v0.1a (Checked in trunk/branch 1.8 & 1.8.0)

Changes since v0.1:
* Moved rest of code from else to before if and removed additional clearing of
gSearchSession as suggested by Neil.

Comment 5

[[e-mail]]

Comment on attachment 199854 [details] [diff] [review]
Tweaked simple patch v0.1a (Checked in trunk/branch 1.8 & 1.8.0)

Sorry, reviewed but forgot to mark this yesterday.

Comment 6

[Ian Neal]

Comment on attachment 199854 [details] [diff] [review]
Tweaked simple patch v0.1a (Checked in trunk/branch 1.8 & 1.8.0)

Checking in
commandglue.js;
new revision: 1.261; previous revision: 1.260
searchBar.js;
new revision: 1.43; previous revision: 1.42
done

Comment 7

[Ian Neal]

Comment on attachment 199854 [details] [diff] [review]
Tweaked simple patch v0.1a (Checked in trunk/branch 1.8 & 1.8.0)

Checking in
commandglue.js;
new revision: 1.258.4.1; previous revision: 1.258
searchBar.js;
new revision: 1.42.4.1; previous revision: 1.42
done

Comment 8

[Ian Neal]

Comment on attachment 199854 [details] [diff] [review]
Tweaked simple patch v0.1a (Checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8.0)
commandglue.js;
new revision: 1.258.10.1; previous revision: 1.258
searchBar.js;
new revision: 1.42.10.1; previous revision: 1.42
done