311379 - animation and image loading in canvas no longer works in beta 2

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Andrew Wooldridge]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

If you view this page in beta 1 FF you'll see an animated background along with
images for a little character that can move around. In beta 2 all that shows up
is the background which fails to move. I see no js errors in my console.  

Reproducible: Always

Steps to Reproduce:
1.Load site url
2.Observe canvas


Actual Results:  
Canvas shows up but with no animation and missing images

Expected Results:  
Canvas should show an animated background and a character moving via keyboard
presses - as is in beta1

Comment 1

[Andrew Wooldridge]

Note that the user agent I used to post the bug is not the one I used to test
the canvas.. obviously...

Comment 2

[Peter van der Woude [:Peter6]]

see warnings in JSConsole

Warning: assignment to undeclared variable knight
Source file: http://andrewwooldridge.com/canvas/canvasgame001/canvasgame002.html
Line: 19

Warning: assignment to undeclared variable knifeTimer
Source file: http://andrewwooldridge.com/canvas/canvasgame001/canvasgame002.html
Line: 29

Comment 3

[José Jeria]

Works in:
[ 2005-09-27-06-mozilla1.8 ]
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050927 Firefox/1.4

Broken in:
[ 2005-09-28-07-mozilla1.8 ]
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050928 Firefox/1.4

Comment 4

[Peter van der Woude [:Peter6]]

I have 6 builds for that period.
I'll narrow it down in an hour or so. (this will miss 1.5beta2 anyway)

Comment 5

[Peter van der Woude [:Peter6]]

works in 20050927 - 1454pdt build
fails in 20050928 - 0355pdt build

Checkins for that period
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=AviarySuiteBranchTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-27+14%3A10%3A00&maxdate=2005-09-29+03%3A10%3A00&cvsroot=%2Fcvsroot

Comment 6

[Scott MacGregor]

Will re-evaulate if Vlad feels strongly, but I don't think we would stop ship
for this bug.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Don't think we want to stop ship, but we do need to get the bug fixed before RC.
 There's something strange going on, as image loading works fine elsewhere.

Comment 8

[José Jeria]

Ahhh, nice, this WFM with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051012
Firefox/1.4.1

Please confirm that this works and mark it WFM

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) Gecko/20051011
Firefox/1.4.1 ID:2005101123

Fixed by Bug 311381