Last Comment Bug 311381 - Cairo usage of dllmain breaks libxul (1.8 branch)
: Cairo usage of dllmain breaks libxul (1.8 branch)
Status: RESOLVED FIXED
: fixed1.8
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: x86 Windows 95
: -- normal (vote)
: ---
Assigned To: Vladimir Vukicevic [:vlad] [:vladv]
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks: xulrunner-1.8 311379
  Show dependency treegraph
 
Reported: 2005-10-06 11:42 PDT by Benjamin Smedberg [:bsmedberg]
Modified: 2005-10-12 05:18 PDT (History)
2 users (show)
benjamin: blocking1.8rc1+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
xulrunner compilation fix (1.15 KB, patch)
2005-10-11 11:41 PDT, Vladimir Vukicevic [:vlad] [:vladv]
mscott: approval1.8rc1+
Details | Diff | Review

Description Benjamin Smedberg [:bsmedberg] 2005-10-06 11:42:09 PDT
The Cairo upgrade includes a dllmain definition that is incompatible with
libxul. Vlad says this is not necessary and he #ifdefed it out on trunk, so this
bug is to track doing the same thing on branch.
Comment 1 Vladimir Vukicevic [:vlad] [:vladv] 2005-10-11 11:41:39 PDT
Created attachment 199182 [details] [diff] [review]
xulrunner compilation fix

Comment out DllMain; not needed, no risk.  Same thing that's on the trunk (and
essentially the same thing that's happening with the rest of the static
builds).

Note You need to log in before you can comment on or make changes to this bug.