The default bug view has changed. See this FAQ.

[FIX]Pages with frames and JS alert fail to render FF 1.5b2

RESOLVED FIXED in mozilla1.8rc1

Status

()

Core
DOM
P1
normal
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: bz)

Tracking

({fixed1.8, regression, testcase})

Trunk
mozilla1.8rc1
fixed1.8, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
This came from:
http://forums.mozillazine.org/viewtopic.php?t=328434&highlight=

The url testcase fails to render in current trunk builds and in Firefox1.5beta2

This used to work in the 2005-08-24 build, but doesn't work in the 2005-08-25 build:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-08-24+12%3A00%3A00&maxdate=2005-08-25+09%3A00%3A00&cvsroot=%2Fcvsroot

Maybe because of bug 253951?
Blocks: 253951
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) Gecko/20051011
Firefox/1.4.1 ID:2005101113

Same for Branch
Created attachment 199224 [details] [diff] [review]
Fix
Attachment #199224 - Flags: review?
Comment on attachment 199224 [details] [diff] [review]
Fix

This is just a copy of what we do for <body>.  The real issue is that OpenHTML
and CloseHTML do nothing of the sort, so we never actually notify on the kids
of <html> through the normal codepath!	This used to work, sorta, because
StartLayout() didn't happen till we hit CloseFrameset(), but that's no longer
true.
Attachment #199224 - Flags: superreview?(jst)
Attachment #199224 - Flags: review?(bugmail)
Attachment #199224 - Flags: review?
Assignee: general → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Pages with frames and JS alert fail to render FF 1.5b2 → [FIX]Pages with frames and JS alert fail to render FF 1.5b2
Target Milestone: --- → mozilla1.8rc1
Attachment #199224 - Flags: review?(bugmail) → review+
Requesting blocking; I think it's worth getting this regression fixed...
Flags: blocking1.8rc1?

Updated

12 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+
Comment on attachment 199224 [details] [diff] [review]
Fix

sr=jst
Attachment #199224 - Flags: superreview?(jst) → superreview+

Updated

12 years ago
Attachment #199224 - Flags: approval1.8rc1?
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
To expand on that approval request, this should be fairly safe -- we've been
using this exact code for <body> for ages, and the only reason we didn't use it
for <frameset> was because it wasn't strictly necessary.  Now it is.

Updated

12 years ago
Attachment #199224 - Flags: approval1.8rc1? → approval1.8rc1+
Fixed on branch.
Keywords: fixed1.8
Depends on: 312942
Created attachment 217036 [details]
Testcase
Blocks: 311785
It looks like on trunk this got busted by the checkin for bug 311785; I'll try to refix it in bug 315369, probably.
You need to log in before you can comment on or make changes to this bug.