312106 - Caret never gets unpainted

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051009 Firefox/1.6a1

Place caret in location bar at end of URL.
Hold down left arrow.
View textbox full of carets.

I tried to screenshot this behaviour, but when I do the window sort of refreshes
and they disappear. Basically a caret after every letter, unblinking.

Any sort of reflow removes the carets.

Comment 1

[Justin Kerk]

Attachment: Screenshot of problem

Here's a screenshot from Windows XP (also showing that it's not a Linux-specific problem).

Comment 2

[Peter van der Woude [:Peter6]]

*** Bug 324718 has been marked as a duplicate of this bug. ***

Comment 3

[Stuart Parmenter]

This is due to XOR/InvertRect no longer doing a bitwise XOR operation.  We don't really have a good solution to that problem.

One idea for fixing this include having the caret code blit from the backbuffer to the front and then draw the caret on the front.  when it wants to undraw, it should just copy from the back buffer.

I'm sure there are some other ways as well.

Comment 4

[Peter van der Woude [:Peter6]]

can this one be resolved Stuart ?

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060210 Firefox/1.6a1 ID:2006021023 / Cairo

WFM

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

No, it's still an issue, just not as visible -- try moving the caret with the cursor keys in an entry box.

Comment 6

[Justin Kerk]

As was noted on MozillaZine, aside from sometimes cutting off letters, the current hack-fix erases the caret by drawing it over with white - on a site with dark textboxes, you get white leftovers (if you have good eyes you can see this with the yellow address bar on https sites like bugzilla).

Comment 7

[Peter van der Woude [:Peter6]]

Attachment: testcase

Comment 8

[Jean-Marc Desperrier]

Also drawing it over with white is very visible on yellow https url.

There's a related problem (worthy of another bug entry ?). 
With some large url (that also have an rss feed ?), when you move and scroll to the end of the url, the caret gets actually badly positionned wrt the characters in addition to the bad redrawing.

The "Bugs Filed Today" url on bugzilla is a good exemple :
https://bugzilla.mozilla.org/buglist.cgi?product=Core&product=Firefox&product=Mozilla+Application+Suite&product=Thunderbird&product=Toolkit&bug_status=UNCONFIRMED,NEW,ASSIGNED,REOPENED,RESOLVED&chfield=%5BBug%20creation%5D&chfieldfrom=-0d

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

The patch in bug 287813 should fix this.

Comment 10

[Frank Wein [:mcsmurf]]

*** Bug 332507 has been marked as a duplicate of this bug. ***

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 333753 has been marked as a duplicate of this bug. ***

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is fixed by bug 287813. (I confirmed on Windows)

-> FIXED

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sorry, I reopen this. The caret is drawn by black, not invert.

-> REOPEN

Comment 14

[Stuart Parmenter]

if the caret gets unpainted lets close this.  open another bug on the blackness of the caret.

Comment 15

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060418 Firefox/3.0a1 ID:2006041810 [cairo]

verified

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #14)
> if the caret gets unpainted lets close this.  open another bug on the blackness
> of the caret.
> 

I opended bug 334635.

Comment 17

[Jesse Ruderman]

*** Bug 331195 has been marked as a duplicate of this bug. ***