312197 - templatize sanitycheck.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

We could also improve its functionality, e.g. displaying some checkboxes like:

[ ] Run all tests (includes all tests below)

[ ] Send unsent mail
[X] Remove all references to deleted bugs
[X] Perform vote/keyword cache checks
[ ] ...

Comment 1

[Frédéric Buclin]

CrossCheck should offer a way to remove invalid references, not only for bugs.

I think that everytime CrossCheck reports invalid references, a checkbox "remove invalid references" should be available, in front of each test.

Comment 2

[Dave Miller [:justdave]]

I'm not sure templating it is a good idea, except maybe for the menus.  The tests need the incremental output or apache will kill it, since it takes a while to run on larger databases.  Once it's in a template, it all outputs at once.  Unless we have a separate template for each test and invoke them all individually.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> once.  Unless we have a separate template for each test and invoke them all
> individually.

That's what I plan to do, yes. More exactly, one template which will display different data. So you would get something similar to the output when changing several bugs at once.

Comment 4

[Vitaly Fedrushkov]

Localization projects depend on this:

https://bugzilla.mozilla-russia.org/show_bug.cgi?id=252

Comment 5

[Frédéric Buclin]

Attachment: patch, v1

I plan to later implement a form at the bottom (or eventually at the top) of the page summarizing all reported errors and letting you choose which errors to fix in a single shoot (instead of having to click one link at a time as we have to do now). That's one of the reason sanitycheck/list.html.tmpl is named like that. ;)

Comment 6

[Max Kanat-Alexander]

Comment on attachment 256628 [details] [diff] [review]
patch, v1

This looks great to me.

Comment 7

[Max Kanat-Alexander]

Hooray! *cheering can be heard*

Comment 8

[Frédéric Buclin]

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.128; previous revision: 1.127
done
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.69; previous revision: 1.68
done
Checking in skins/standard/admin.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/admin.css,v  <--  admin.css
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/sanitycheck/list.html.tmpl,v
done
Checking in template/en/default/admin/sanitycheck/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/sanitycheck/list.html.tmpl,v  <--  list.html.tmpl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/sanitycheck/messages.html.tmpl,v
done
Checking in template/en/default/admin/sanitycheck/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/sanitycheck/messages.html.tmpl,v  <--  messages.html.tmpl
initial revision: 1.1
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v  <--  messages.html.tmpl
new revision: 1.50; previous revision: 1.49
done

Comment 9

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.