312274 - submenu arrows are not right-aligned

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Steffen Wilberg]

Starting with the 20051012 nightly, the submenu arrows in Thunderbird's menus
are not right-aligned. This is a regression from bug 243078.

Note that Thunderbird uses the Qute theme on Windows and Linux and Pinstripe on
Mac. See http://lxr.mozilla.org/mozilla1.8/source/mail/themes/Makefile.in#46 and
http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/Makefile.in#58. So the
winstripe and pinstripe changes need to be ported to Qute.

Comment 1

[James Ross]

It's not actually obvious *why* they're doing that, at least not without DOMI 
in Thunderbird, which I don't have.

Comment 2

[James Ross]

(what I mean is, it is semi-clear what is cuasing it, but I don't know what 
needs tweaking to fix it without DOMI)

Comment 3

[Scott MacGregor]

just add inspector to your .mozconfig file and you can build thunderbird with
dom inspector. 

Comment 4

[Scott MacGregor]

Attachment: screen shot of broken menus in thunderbird

after everyone promised me this would have no impact to thunderbird in the
triage meeting too :)

Comment 5

[Scott MacGregor]

cc'ing mconnor who volunteered to be on the hook for an regressions issues that
came from 243078.

Comment 6

[Anthony Parsons]

I'm seeing this bug in:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051013 Firefox/1.4.1

Also, the keyboard shortcuts aren't being right-aligned either.

Comment 7

[:Gijs (he/him)]

Silver will not be around until this afternoon. I have a build here with a
somewhat working DOMi (it's broken to the extent that it gives an xml error in
the bottom, but the functionality doesn't seem to be broken regardless). I tried
determining the cause of this, but was unable to do so (I really do need better
skills in css/xul).

James: if you don't have a build to use, I've put mine online @
http://home.student.uva.nl/gijsbert.kruitbosch/mozilla/theming/thunderbird.zip

File is 8.9 MB. Given experiences yesterday, I somehow doubt it would have been
faster to email it ;-).

Checkout was yesterday evening around 7pm CET. I'll update my build after I
return home from uni, but I'm guessing that will be significantly later than
when you will arrive home.

Comment 8

[Alfred Kayser]

This is the code needed in menu.css to make the submenu arrows behave.

menu > stack,
menuitem > stack, 
.menu-inner-content { -moz-box-flex: 1; }

To fix the accelerators this patch works:
.menu-inner-content > hbox { -moz-box-pack: end; } 

Note, this is not just Thunderbird, but also Firefox, Seamonkey, all using the
1.8 toolkit

Comment 9

[Asa Dotzler [:asa]]

no longer a problem with the backout at  243078

Comment 10

[Scott MacGregor]

This is now working for me with the backout.