312304 - Graphviz installation for Bugzilla doesn't work if spaces are in the path to dot.exe

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[image]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

If the installation is done according the 
http://www.bugzilla.org/docs/win32install.html instructions, the path to 
dot.exe is C:/Program Files/ATT/Graphviz/bin/dot.exe. But the CGI script 
showdependencygraph.cgi then doesn't work.
If the path to dot.exe is forced without spaces (e.g. 
C:/ATT/Graphviz/bin/dot.exe) it workes fine

Reproducible: Always

Steps to Reproduce:
See above

Comment 1

[:glob ✱]

the line in question is:

  open(DOT, "$webdotbase -Tpng $filename|");

so this will affect all platforms with spaces in the path.

i can't test thing out right now, but i suspect this line should be:

  open(DOT, qq("$webdotbase" -Tpng $filename|));


suspect lines:

showdependencygraph.cgi:236:
open(DOT, "$webdotbase -Tpng $filename|");

showdependencygraph.cgi:255:
open(DOT, "$webdotbase -Tismap $filename|");

Bugzilla/BugMail.pm:613:
open(SENDMAIL, '|' . SENDMAIL_EXE . ' -t -i') ||

attachment.cgi:553:
open my $interdiff_fh, "$::interdiffbin $old_filename $new_filename|";

collectstats.pl:99:
open(CGI, "$perl -T duplicates.cgi |")

Comment 2

[image]

Thanks for the quick response. I am not able to test all the supposed changes, 
but first two works fine now !!!

I also suggest to add errorchecking in the open statements, like

  open(DOT, qq("$webdotbase" -Tpng $filename|))
    or die "Can't open file: $!\n";

Then possible problems are faster to analyse.

Comment 3

[Olav Vitters]

Newer bug has a patch.

*** This bug has been marked as a duplicate of 326080 ***

Comment 4

[Marc Schumann [:Wurblzap]]

*** Bug 326080 has been marked as a duplicate of this bug. ***

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 6

[Marc Schumann [:Wurblzap]]

Let's go for the 2.20 branch, even.

Comment 7

[Frédéric Buclin]

Comment on attachment 210861 [details] [diff] [review]
Patch

r=LpSolit for both 2.20 and tip.

Comment 8

[Marc Schumann [:Wurblzap]]

Tip:
Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <--  showdependencygraph.cgi
new revision: 1.48; previous revision: 1.47
done

2.20 branch:
Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <--  showdependencygraph.cgi
new revision: 1.38.4.2; previous revision: 1.38.4.1
done