312386 - Checksetup fails to check for existing group_group_map for new admins

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[A. Karl Kornel]

bug 298688 created 2 groups, sudoers and sudo_protect.  When checksetup.pl creates the groups, it 
automatically inserted rows into group_group_map so that:

* All members of the admin group get membership in the sudoers group
* All members of the admin group get bless privileges in the sudoers group
* All members of the admin group get bless privileges in the sudo_protect group
* All members of the sudoers group get membership in the sudo_protect group

However, there is a small problem with this.  On lines 4418 to 4425 of checksetup.pl, a 
group_group_map entry is inserted for every group so that administrators are made members of each 
non-admin group.  Of course, for sudoers and sudo_protect this has already been done!

Comment 1

[Joel Peshkin]

Attachment: check before re-adding group_group_map entries

Comment 2

[Frédéric Buclin]

Comment on attachment 199490 [details] [diff] [review]
check before re-adding group_group_map entries

karl wrote the original code. I want his opinion on it.

Comment 3

[A. Karl Kornel]

The original bug is bug 204498.

Comment 4

[A. Karl Kornel]

Comment on attachment 199490 [details] [diff] [review]
check before re-adding group_group_map entries

This is essentially the same patch I was going to make (I was going to use
COUNT(*) and 
selectrow_array).  I do have 2 nits (using ' vs. ", and right-aligning the
WHERE and AND lines), but they can be easily ignored (they might not even be
nits).

On the testing end, I managed to run checksetup on a fresh installation without
crashing.  As far as I can see it is fine.

Comment 5

[Frédéric Buclin]

Comment on attachment 199490 [details] [diff] [review]
check before re-adding group_group_map entries

r=LpSolit by inspection, and based on karl's review

Comment 6

[Frédéric Buclin]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.442; previous revision: 1.441
done

Comment 7

[Frédéric Buclin]

2.20 is affected too. The patch applies cleanly and works correctly.

Comment 8

[Frédéric Buclin]

*** Bug 224695 has been marked as a duplicate of this bug. ***

Comment 9

[Frédéric Buclin]

2.20:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.13; previous revision: 1.412.2.12
done