312478 - View message source: Wrap long lines toggle does not do anything

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Lucius Chiaraviglio]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

If you view the source of a message with long lines and then select "Wrap long
lines" (in the View menu), nothing happens (even tried resizing the window and
re-toggling).  The long lines stay non-wrapped.

This does not affect the normal message viewing panes and windows.  This problem
also does NOT occur in the Firefox 1.5 Beta 2 page source viewer.


Reproducible: Always

Steps to Reproduce:
1.  Find a message in your Inbox that has long lines.
2.  View message source.
3.  If the lines do not extend past the window boundary, resize the window smaller.
4.  Note the display of the long lines.
5.  Under the View menu of the message source viewer, select "Wrap long lines",
or unselect it if it is already selected.

Actual Results:  
The long lines stay wrapped, regardless of the status of the "Wrap long lines"
flag (which does display correctly in the View menu).

Expected Results:  
When the "Wrap long lines" flag is set (and only when it is set), long lines
should be wrapped (like they are in the page source viewer of Firefox 1.5 Beta 2).

Comment 1

[Lucius Chiaraviglio]

The Thunderbird version noted above is 1.5 Beta 2.

Comment 2

[Mike Cowperthwaite]

Confirming; reproduced with 1.5b2-1006 and 1.6a1-1003, as well 1.0.6, Win2K.
Toggling that menu does toggle the preference   view_source.wrap_long_lines
The feature works in Seamonkey 1.0a-1006.  xref bug 116688.

Comment 3

[Mikel Ward]

Attachment: sample message containing a long line

The body of this message is one very long line of HTML.  View->Wrap Long Lines has no effect.

Comment 4

[diorser]

Wrap bug still exist in TB2B1.

Comment 5

[Geoff Lankow (:darktrojan)]

And in 3.0a3

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

The wrapping is done by applying a css style, so it helps if we package the file those css rules are in...

I don't know why we don't have a packages-static for unix, but anyway, this seems to work.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 344337 [details] [diff] [review]
proposed fix

It even fixes it on mac.

I wish packages-static was better organised. sigh. Could you put the addition just after the bin\res\forms.css? It at least keeps them together.

fwiw Phil was working on a patch for a unix packages-static.

Comment 8

[Magnus Melin [:mkmelin]]

changeset:   699:fc525adeab4c
http://hg.mozilla.org/comm-central/rev/fc525adeab4c

->FIXED