312501 - Use a custom alert_exclamation icon in error page

Status: VERIFIED FIXED

(Camino Graveyard :: General, enhancement)

Description

[Jasper]

We should use a custom icon for the error pages, the default classic alert icon
is old and looks bad in comparisson with the rest of the icons in our app.

Comment 1

[Jasper]

Attachment: proposed icon

The proposed icon, this should look much better.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I agree 1000%, but the problem is we're getting all the ugly error page branding
from embed.jar, so until bug 302309 is fixed (Gecko 1.9 maybe), this bug is as
dead in the water as bug 303193.  Unless there's a way to tell Camino not to
look in embed.jar for stuff--which would solve a whole host of bugs!

(I actually think we should use a Camino+alert icon like the dialogues, but....)

Comment 3

[Jasper]

Well that's not the a camino icon but the one provided by the OS, I however
think that one really doesn't work at small sizes as it's yellow and white (very
light) that's why we use our own icon for the tab alert icon.

Comment 4

[Samuel Sidler (old account; do not CC)]

Are we sure we need those patches? Epiphany has it's own error pages, why can't we?

Comment 5

[Simon Fraser [no longer active]]

*** Bug 326478 has been marked as a duplicate of this bug. ***

Comment 6

[Mark Mentovai]

Unless someone's got a good reason to not do it, I intend to replace alert-exclaim.gif on the 1.0 branch with this icon the quick 'n' dirty way.

Comment 7

[Mark Mentovai]

Landed icon quick 'n' dirty for 1.0.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Moving this to 1.1 to sync with bug 303193, although I really don't expect we'll get any traction on the core bug 302309 until at least 1.2 era :-(

On the other side, the same hack mento did for 1.0 will be needed for 1.0.1, so nominating for blocking since (hopefully!) every single other minibranch patch from 1.0 will land before 1.0.1.

Comment 9

[Chris Lawson (gone)]

Alternatively, may be dependent on bug 330421. Either that or 302309 needs to get fixed for this to be permanently fixed so we don't have to keep doing the quick-n-dirty thing every time we want to release.

cl

Comment 10

[Mark Mentovai]

Fixed on the three branches with bug 330421, so this won't be so quick 'n' dirty for 1.0.1.

Comment 11

[Mark Mentovai]

Marking [camino-1.0.1] although this fix landed on 1_8_0 prior to the CAMINO_1_0_1_MINIBRANCH.