330421 - Allow arbitrary replacement of embed.jar members

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mark Mentovai]

Right now, we're stuck with the embed.jar that the core gives us.  I landed a custom icon on the 1.0 minibranch to avoid obscene ugliness (bug 312501), but there should be a more workable solution, even if it is only temporary and embedding is eventually fixed to not be so evil about this stuff.

My current solution is to provide a directory (mozilla/camino/embed-replacements) that serves as a hierarchy containing files to replace in (or add to) embed.jar.  Processing on embed.jar would occur prior to building Camino with xcodebuild.

Comment 1

[Mark Mentovai]

Attachment: Replace members of embed.jar

zip options used: -r (recusive), -0 (no compression), -D (don't add members for directories), -X (don't add extended Unix attributes).  This causes replaced/added members to exist in the zip file in the same way that they would if they had been added the "normal" way by make-jars.pl.

To use this, create a directory mozilla/camino/embed-replacements.  To use it to beautify the error pages (bug 312501), place attachment 199596 [details] at mozilla/camino/embed-replacements/skin/classic/global/icons/alert-exclam.gif.

Comment 2

[Mark Mentovai]

Comment on attachment 214971 [details] [diff] [review]
Replace members of embed.jar

Oh, this doesn't exclude CVS crap in non-objdir builds.

Comment 3

[Mark Mentovai]

Attachment: Works for srcdir and objdir builds

zip doesn't have powerful enough exclude lists to handle something simple like "exclude all directories named CVS and their children," so I'll rsync for both types of builds.  Here, I've moved to rsync -C, which sets up a nice healthy exclude list that also keeps out *.orig and .##* and other things CVS might create.

Comment 4

[Samuel Sidler (old account; do not CC)]

Is this only a temporary solution (for the 1.8 branch, I'd guess) until the trunk fixes the overall issue?

Comment 5

[Mark Mentovai]

It can be temporary if these pages become customizable for embedders, but there's no good reason we shouldn't be able to replace arbitrary members of embed.jar.  We already are able to pick and choose what we want to take from the core by adding and removing things from the project file.  We don't have this ability (yet) for embed.jar only because Xcode can't see inside zip files.

Comment 6

[Mark Mentovai]

r?

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 214973 [details] [diff] [review]
Works for srcdir and objdir builds

sr=pink

Comment 8

[Håkan Waara]

Comment on attachment 214973 [details] [diff] [review]
Works for srcdir and objdir builds

Looks good. 

How about also hiding the temp folder (".embed-replacements")?

r=me either way.

Comment 9

[Mark Mentovai]

Landed on the three branches so there's one less thing to do on the 1.0.1 minibranch.

Comment 10

[Mark Mentovai]

(Hidden things are evil!  Don't be evil!)