312636 - [BeOS]Refactoring two getters in widget for faster mouse processing

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

two methods:
EventIsInsideWindow()
and
GetParent()
are permanently called at mouse events.
with refactoring GetNativeData() to differentiate Window and Widget we can
perform first with less overhead - no locking, no conversion.
Also, it may help in future with embedded code, but it remains to see.
GetParent now also uses very suspicios pointer conversion from BView which also
wouldn't work e.g. with InvisibleWindows, if we need those in future.
Other platforms tend to use here cached mParent value

Comment 1

[Sergei Dolgov]

Attachment: patch

Refactors two getters, changes EventIsInsideWindow() to use BWindow::Frame()
and adds safety check (related to GetNative) to Scroll()

Comment 2

[tqh]

Comment on attachment 199755 [details] [diff] [review]
patch

r=[e-mail]

looks good ok to me.

Comment 3

[Sergei Dolgov]

landed in trunk
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.100; previous revision: 1.99
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.39; previous revision: 1.38
done

Comment 4

[Niels Reedijk]

Add to improvements to the MOZILLA_1_8_BRANCH

Comment 5

[Niels Reedijk]

Attachment: Patch for 1_8 branch

Patch for the 1.8 branch. Should be identical, except for one curly brace being placed in a different spot. 

This change is BeOS only and will not affect any other platform.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 230159 [details] [diff] [review]
Patch for 1_8 branch

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 once you have.

Comment 7

[Niels Reedijk]

Needs checkin from someone

Comment 8

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.10; previous revision: 1.91.4.9
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.35.4.6; previous revision: 1.35.4.5
done

Comment 9

[Niels Reedijk]

Remove checkin request, since it's checked in. Thanks!