Closed Bug 312896 Opened 19 years ago Closed 19 years ago

tab strip should not respond to double click in space above and below tabs

Categories

(Firefox :: Tabbed Browser, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 2 alpha1

People

(Reporter: beltzner, Assigned: Gavin)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

There is a small area in the tab strip both above (about 5px) and below (about
2px) tabs which responds to a double-click event by opening a new tab. This can
lead to unexpected behaviour where new (blank) tabs open and steal UI focus:

 - user tries to select a tab
 - user misses and clicks in area above/below tab
 - user tries a second click, opening a new tab

These areas shouldn't respond to the double-click accelerator for creating new tabs.
Quick hack: change (localName != "toolbarbutton") to (localName == "spacer") in
onTabBarDblClick. The double click handler really should just be on the spacer.
This is pretty much a dup of bug 218701.  I'm not marking it as such because
Gavin's fix would fix other bugs (not the same bugs that fixing bug 218701 would
fix).
I think you're being too generous - this seems like a full on dupe to me! But
I'll take your word for it.
Assignee: nobody → gavin.sharp
Version: 1.5 Branch → Trunk
Status: NEW → ASSIGNED
Priority: -- → P3
Attached patch something that works (obsolete) — Splinter Review
This seems to work, but it makes tabbrowser depend on a certain implementation of tabbox... which I don't think is a good idea.
I'm not sure why we need interchangeable tabbox bindings, really.  I'm pretty sure that we make plenty of assumptions about the nature of the tabbox we're using.
Attached patch add commentSplinter Review
Attachment #201390 - Attachment is obsolete: true
Attachment #201471 - Flags: review?
Attachment #201471 - Flags: review? → review?(mconnor)
Whiteboard: [patch-r?]
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/tabs/ 

http://weblogs.mozillazine.org/ben/archives/009210.html 11/3/05

doesn't even allow for "doubleclick on tab bar=new tab" anymore...
but it's not an official build though
Attachment #201471 - Flags: review?(mconnor) → review+
Checked in on the trunk.
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.125;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking-aviary2?
Resolution: --- → FIXED
Whiteboard: [patch-r?]
Target Milestone: --- → Firefox1.6-
Attachment #201471 - Flags: approval1.8.1?
Attachment #201471 - Flags: approval1.8.1? → approval1.8.1+
Flags: blocking-firefox2? → blocking-firefox2+
Checked in on the 1.8 branch for Firefox 2.
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.103.2.15;
Target Milestone: Firefox 2 → Firefox 2 alpha1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: