In the "My Votes" page, the "Votes" text box should be a checkbox, since after the policy change you cannot vote more than once anyway
firstname.lastname@example.org is the new owner of Bugzilla and Bonsai. (For details, see my posting in netscape.public.mozilla.webtools, news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
*** Bug 38134 has been marked as a duplicate of this bug. ***
I think for other components such as webtools there is still more than one vote allowed, so for those components an option menu would certainly be appropriate. (At least I have just seen somebody giving five votes to a bug.) I would like to vote for this bug, but I can't. See bug 41519.
I'm attaching a patch to showvotes.cgi which does the following: - if the max number of allowed votes per bug is one, it offers a checkbox, - if that number is less than ten, it offeres a selection, - else the behaviour is unchanged (text input). Additionally products without any votes tabulated are now omitted since I don't find them very interesting and without them you maybe don't have to scroll to see everything. But that's just a one-line change, you can leave it out if you don't like it. Unfortunately I can't test this since I don't have mySQL et al installed. So can somebody please review and test this patch (and maybe even check it in)? Thanks! - Stephan.
Keywords: patch, review
I attached a patch two months ago. What should I do to get this checked in? Isn't this the appropriate place here?
I think a selection of numbers is a bit much. I'd much prefer a textbox or a checkbox.
I'm with Matt. I think the select box is a bit much. Post a new patch with just the checkbox and the text box if you can.
Okay, I'll do that in the next few days.
Status: NEW → ASSIGNED
Oops, I meant to reassign the bug to myself before accepting ...
Assignee: tara → st.n
Status: ASSIGNED → NEW
Attached is the modified patch without the selection. Now you get either a checkbox or a text input. Please review and test. Again, I can't test this because I don't have my own Bugzilla installation, sorry.
Maybe this could also make it for 2.12?
This patch causes globals.pl to barf when showvotes.cgi is invoked: SELECT products.product, products.maxvotesperbug FROM products: Table 'products' was not locked with LOCK TABLES at globals.pl line 171 I'll try to dig into this a bit later, but if you could have a look at it it would more likely make the 2.12 cut.
Okay, I didn't know I have to lock a table before trying to read from it. Now I changed SendSQL("lock tables bugs read, votes write"); to SendSQL("lock tables bugs read, products read, votes write"); which should fix this. Please test again. Thanks!
I now have patched my personal copy of BugZilla 2.11 (cvs pull from yesterday) with this patch, and it's working quite well. I think this is the right way to do this, looks nice!
r= email@example.com installed on my test system, works as advertised.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
I look forward to seeing it in action here.
*** Bug 69754 has been marked as a duplicate of this bug. ***
Sorry for the spam, but I needed to be able to query for all of these correctly.
Target Milestone: --- → Bugzilla 2.12
Can't verify, as no "One vote only" components on landfill. Either that, or this doesn't work. :-) Gerv
Verified, this is present on the Mozilla products on mozilla.org.
Status: RESOLVED → VERIFIED
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
You need to log in before you can comment on or make changes to this bug.