313018 - select1 size incorrect when populate from itemset

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Nick Jones]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511

select1 does not resize to contain text when populated from itemset. It does
when populate by a series of item tags.

Reproducible: Always

Comment 1

[Nick Jones]

Attachment: select1 populate by item

Comment 2

[Nick Jones]

Attachment: select1 populate by itemset

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 200130 [details] [diff] [review]
proposed patch

The C++ part of the itemset is nowadays nsXFormsDelegate, so the UI part can
now implement nsIXFormsUIWidget and get all the fixes related to PostRefresh.

Comment 5

[aaronr]

Comment on attachment 200130 [details] [diff] [review]
proposed patch

I don't have a problem with the patch, but I don't see any difference with the
attached testcases before or after I compile in the patch.  Is there a more
obvious testcase?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #5)
> (From update of attachment 200130 [details] [diff] [review] [edit])
> I don't have a problem with the patch, but I don't see any difference with the
> attached testcases before or after I compile in the patch.  Is there a more
> obvious testcase?
> 

Hmm, the patch should fix the problem with the second test case.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 200130 [details] [diff] [review] [edit] [edit])
> Hmm, the patch should fix the problem with the second test case.

And this fixes the size problem in bug 312301.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

checked in to trunk

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

*** Bug 312301 has been marked as a duplicate of this bug. ***

Comment 10

[Doron Rosenberg (IBM)]

Hmm, on branch, this patch doesn't seem to fix the issue for me.

Comment 11

[aaronr]

(In reply to comment #10)
> Hmm, on branch, this patch doesn't seem to fix the issue for me.

Nope, doesn't work on branch for me either.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #10)
> Hmm, on branch, this patch doesn't seem to fix the issue for me.
> 

Strange. I'll look at it tomorrow. (Way too late atm.)
Does the patch still fix Bug 312301?

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch for 1.8

I have no idea why the select->Refresh(); was commented out o_O

Comment 14

[Doron Rosenberg (IBM)]

checked into branch

Comment 15

[Charles Brunet]

Attachment: Testcase with default value

select1 size is incorrect when a default value is given.

Comment 16

[aaronr]

(In reply to comment #15)
> Created an attachment (id=219066) [edit]
> Testcase with default value
> 
> select1 size is incorrect when a default value is given.
> 

This works fine on the trunk.  Fixed by bug 333045 which didn't make it into 0.5.  Will be in 0.6.