select1 size incorrect when populate from itemset

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
10 months ago

People

(Reporter: Nick Jones, Assigned: smaug)

Tracking

({fixed1.8})

Trunk
x86
Windows XP
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511

select1 does not resize to contain text when populated from itemset. It does
when populate by a series of item tags.

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 200092 [details]
select1 populate by item
(Assignee)

Updated

12 years ago
Assignee: aaronr → smaug
(Reporter)

Updated

12 years ago
Attachment #200092 - Attachment description: select1 populate by itemset → select1 populate by item
(Reporter)

Comment 2

12 years ago
Created attachment 200093 [details]
select1 populate by itemset
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

12 years ago
Created attachment 200130 [details] [diff] [review]
proposed patch
(Assignee)

Updated

12 years ago
Attachment #200130 - Flags: review?(doronr)
(Assignee)

Comment 4

12 years ago
Comment on attachment 200130 [details] [diff] [review]
proposed patch

The C++ part of the itemset is nowadays nsXFormsDelegate, so the UI part can
now implement nsIXFormsUIWidget and get all the fixes related to PostRefresh.
Attachment #200130 - Flags: review?(aaronr)
(Assignee)

Updated

12 years ago
Blocks: 312301

Updated

12 years ago
Attachment #200130 - Flags: review?(doronr) → review+

Comment 5

12 years ago
Comment on attachment 200130 [details] [diff] [review]
proposed patch

I don't have a problem with the patch, but I don't see any difference with the
attached testcases before or after I compile in the patch.  Is there a more
obvious testcase?
Attachment #200130 - Flags: review?(aaronr) → review+
(Assignee)

Comment 6

12 years ago
(In reply to comment #5)
> (From update of attachment 200130 [details] [diff] [review] [edit])
> I don't have a problem with the patch, but I don't see any difference with the
> attached testcases before or after I compile in the patch.  Is there a more
> obvious testcase?
> 

Hmm, the patch should fix the problem with the second test case.

(Assignee)

Comment 7

12 years ago
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 200130 [details] [diff] [review] [edit] [edit])
> Hmm, the patch should fix the problem with the second test case.

And this fixes the size problem in bug 312301.

(Assignee)

Comment 8

12 years ago
checked in to trunk
Whiteboard: xf-to-branch
(Assignee)

Updated

12 years ago
No longer blocks: 312301
(Assignee)

Comment 9

12 years ago
*** Bug 312301 has been marked as a duplicate of this bug. ***
Hmm, on branch, this patch doesn't seem to fix the issue for me.

Comment 11

12 years ago
(In reply to comment #10)
> Hmm, on branch, this patch doesn't seem to fix the issue for me.

Nope, doesn't work on branch for me either.
(Assignee)

Comment 12

12 years ago
(In reply to comment #10)
> Hmm, on branch, this patch doesn't seem to fix the issue for me.
> 

Strange. I'll look at it tomorrow. (Way too late atm.)
Does the patch still fix Bug 312301?

(Assignee)

Comment 13

12 years ago
Created attachment 200636 [details] [diff] [review]
proposed patch for 1.8

I have no idea why the select->Refresh(); was commented out o_O
Attachment #200636 - Flags: review?(doronr)
(Assignee)

Updated

12 years ago
Attachment #200636 - Flags: review?(aaronr)

Updated

12 years ago
Attachment #200636 - Flags: review?(doronr) → review+

Updated

12 years ago
Attachment #200636 - Flags: review?(aaronr) → review+
checked into branch
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch → fixed1.8

Updated

12 years ago
Keywords: fixed1.8
Whiteboard: fixed1.8

Comment 15

11 years ago
Created attachment 219066 [details]
Testcase with default value

select1 size is incorrect when a default value is given.

Comment 16

11 years ago
(In reply to comment #15)
> Created an attachment (id=219066) [edit]
> Testcase with default value
> 
> select1 size is incorrect when a default value is given.
> 

This works fine on the trunk.  Fixed by bug 333045 which didn't make it into 0.5.  Will be in 0.6.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.