Closed Bug 313083 Opened 19 years ago Closed 19 years ago

Right-click in empty tab bar space has no contextual menu

Categories

(Camino Graveyard :: Toolbars & Menus, enhancement)

Product:
Camino Graveyard
Component:
Toolbars & Menus
Platform:
PowerPC
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

fixes lack of menu
1.15 KB, patch
stuart.morgan+bugzilla
: review+
mark
: superreview+
Details | Diff | Splinter Review
fixed nib file
24.86 KB, application/zip
stuart.morgan+bugzilla
: review+
mark
: superreview+
Details 
A right-click/ctrl-click in the empty space of the tab bar should generate a
contextual menu containing, at minimum, the following items:

*Reload all tabs
*New tab
*Close all tabs (closes window without warning, regardless of preference from
bug 196359, since the user is being explicitly informed this will close all tabs)

Right now, there's no menu generated at all.
We talked about this in bug 291901 and never came to a resolution; Wevah and
Jasper were in favor of it.
Taking, just for the challenge of it. Simon, I may want your help on this one later. ;)

cl
Assignee: mikepinkerton → bugzilla
You'd implement -menu or -menuForEvent: on BrowserTabBarView.
I don't think we want a "Close All Tabs" context menu item. Very confusing to choose this and have the window disappear.
Fixes code; nib file coming as soon as I get my trunk updated.

cl
Attachment #216490 - Flags: review?(stuart.morgan)
Attached file zipped up nib file with changes in it (obsolete) — 

  

  



        Attachment #216492 -
        Flags: review?(stuart.morgan)

    
    

    
  
Comment on attachment 216492 [details]
zipped up nib file with changes in it

Can we try again with a nib where the menu items have action connections, instead of being dead?

  

  



        Attachment #216492 -
        Flags: review?(stuart.morgan) → review-

    
    

    
  

      
      
      
      

        Attached file
          
        fixed nib file
        — 
      

    


  
(In reply to comment #7)
> Can we try again with a nib where the menu items have action connections,
> instead of being dead?

We sure can. Sorry about that!

cl

  

  



        Attachment #216492 -
        Attachment is obsolete: true

        Attachment #216884 -
        Flags: review?(stuart.morgan)

    
  

        Attachment #216490 -
        Flags: review?(stuart.morgan) → review+

    
    

    
  
Comment on attachment 216884 [details]
fixed nib file

Sorry I forgot about this.  Looks good, so r=me (although someone should make sure the nib changes are to an up-to-date BW).

  

  



        Attachment #216884 -
        Flags: superreview?

        Attachment #216884 -
        Flags: review?(stuart.morgan)

        Attachment #216884 -
        Flags: review+

        Attachment #216884 -
        Flags: superreview? → superreview?(mikepinkerton)

    
  

        Attachment #216884 -
        Flags: superreview?(mikepinkerton) → superreview+

    
  

        Attachment #216490 -
        Flags: superreview+

    
    

    
  
Checked in on trunk and MOZILLA_1_8_BRANCH.

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: