313101 - HTTP auth dialog is titled "Prompt"

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Try to load http://www.squarefree.com/stats/

Result: HTTP Auth dialog comes up.  Its title is "Prompt".

Expected: A title like "Firefox" or "Password required".  (Beltzner?)

Comment 1

[Jesse Ruderman]

Happens on Mac too (with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.9a1) Gecko/20051019 Firefox/1.6a1).  On Mac, the title is shown in bold in
the body of the sheet.

Comment 2

[Jesse Ruderman]

Originally reported by Burning Edge reader Moktoipas as a comment on
http://www.squarefree.com/burningedge/2005/10/19/2005-10-19-branch-builds/.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

easier to fix after bug 265780  

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Note that this is the same as in 1.0.7, so in answer to Matthias' question on
the Burning Edge, "yes, this seems to be normal."

That doesn't make it right, of course. "Password Requested" sounds right to me. :)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

well, the dialog hasn't had a title at least since 1.2 <[e-mail]>
2001-05-11 14:03

(I didn't feel like trying to find the file where this code was in earlier...)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch?

This changes the default title for PromptUsernameAndPassword and PromptPassword, for Firefox and Seamonkey. I guess this might be better if this had an explicit title instead of falling back to the default (which is what I assume the dependency on bug 265780 is about), but I don't think that should prevent us from using a better default, right?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

*** Bug 333522 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 215600 [details] [diff] [review]
patch?

So, this will probably seem insane, but for localizers to be aware of the change, we have to change the property name, otherwise they don't know we've updated the string in en-US and they need to retranslate...

Comment 9

[Darin Fisher]

Are you serious?  That message has not been widespread enough.  I see changes to strings happening all the time.  Are you sure that's the best solution?  Why don't they just check bonsai logs?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

As far as I know, they mostly rely on the result of compare-locales, which is run on the l10n tinderboxen. It only shows failure if keys are added or removed (or renamed). I thought the rule was therefore that the requirement was to change the key if it's semantics change, not every time it's value changes.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Though I notice that most other locales have just translated the en-US string directly. Changing the key will let them know to make the same improvement we're making.

Comment 12

[[e-mail]]

I don't know about you but it prompts "Password" when I try that URL.

Comment 13

[Darin Fisher]

Attachment: v1.1 patch

Comment 14

[Darin Fisher]

fixed-on-trunk, fixed1.8.1