313392 - Localizable files for reporter should be moved from main source tree to /l10n

Status: VERIFIED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Søren Munk Skrøder (extended hiatus)]

Currently the localizeable files for the reporter resides in the main source
tree (along the XUL code for the feature) -- those files should be moved to the
/l10n tree, since reporter no longer is considered an extension...

Comment 1

[Axel Hecht [:Pike]]

It'd be probably a good thing to have robert and bsmedberg confirm this.

Comment 2

[Benjamin Smedberg]

This is correct.

Comment 3

[Axel Hecht [:Pike]]

Taking this bug.

Comment 4

[Axel Hecht [:Pike]]

The upcoming patch requires to back-port the localizations for 
bg, de, and eu;
The localizations for 
ca, cs, da, el, es-AR, fi, fr, ga-IE, gu-IN, he, hu, hy-AM, ko, mk, mn, nb-NO,
nl, pa-IN, ro, ru, sk, sl
differ.

I'm taking nominations on what to do with those. You can choose between 
back-port and leave-alone for trunk, I'll back-port for moz18.
This is basically in order to have control over the changes between 1.5 and 2.

I'm not sure if I target the 1.5.0.x releases right now for the /cvsroot
changes. It may be good to have it in a second step if we want to take new
locales on the 1.5.0.x route. Which would be good.

Comment 5

[Pavel Franc - Mozilla.cz]

Regarding cs, the localization in l10n tree of trunk and 1.8 branch is the correct one. There was a bug 313678 to update the main tree but it came too late.  

Comment 6

[Benoit]

In fr, the difference is negligible (just one word AFAICT). You can either include or ignore the changes depending of what is easier for you.

Comment 7

[Chase Phillips]

Axel, is this bug in scope for 1.5.0.1?  If so, what needs to happen to nail it to the wall?

Comment 8

[Benjamin Smedberg]

No, this is not in scope for 1.8.0.1 and unless there are overwhelming arguments I'd argue not for 1.8.0.x at all. Let's do this on 1.8/trunk.

Comment 9

[Axel Hecht [:Pike]]

I just landed the reporter files for fy-NL and lt on the 1.8.0 branch to get those
locales in better shape for the fx 1.5.0.x release cycle.

Comment 10

[Axel Hecht [:Pike]]

Attachment: fix reporter build logic

This is the fix to the actual reporter files, I didn't attach the changes to the 
localizations.
I tried to move the Makefiles as close to the standard set by dom, netwerk etc,
removing the NO_JAR_AUTO_REG in favour of moving the contents.rdf into the 
seamonkey part of the jar.mn.

Comment 11

[Axel Hecht [:Pike]]

Attachment: changes checked in to MOZILLA_1_8_BRANCH

I checked in the current state of reporter in /cvsroot on the 
MOZILLA_1_8_BRANCH. I'm going to leave trunk alone, but I would like to bootstrap
our Firefox 2 developement with the state of the localization that fx1.5 has.
This includes line ending fixes etc.
I tagged the tree afterwards for reference. The affected locales are
bg ca cs da de el es-AR eu fi fr ga-IE gu-IN he hu hy-AM ko mk mn nb-NO nl pa-IN pt-BR ro ru sk sl

I checked this in in preparation of the opening of the 1.8 branch for 2.0
developement, this is getting time critical and the actual build foo doesn't
go in fast enough.

Affected locales are invited to take a close look at the actual changes I did
to see what they should do with their local changes. Please don't just plain
revert, you may add back line ending bustages or the like.

A sample bonsai query for the changes would be (for bg),
http://bonsai-l10n.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=l10n%2Fbg%2Fextensions%2Freporter&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-01-27+5%3A00&maxdate=2006-01-27+5%3A45&cvsroot=%2Fl10n
Once you checked that I didn't change something useful, you may want to look at
the "Show commands which could be used to back out these changes" link to show
how to get back to your old version.

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 209482 [details] [diff] [review]
fix reporter build logic

Requesting approval and second review from Robert for landing on the 1.8 branch and trunk

Comment 13

[Axel Hecht [:Pike]]

Checked in on trunk and MOZILLA_1_8_BRANCH

Comment 14

[Marek Stępień [:marcoos, inactive]]

Verified.

Trunk l10n tinderbox is green at last. :)

Comment 15

[Axel Hecht [:Pike]]

removed the stale localizations in mozilla/extensions/reporter, too.
Filed bug 326348 about actually running compare-locales on reporter again.