326348 - l10n firefox tinderboxens, trunk, 1.8, need to check reporter

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect, P3)

Description

[Axel Hecht [:Pike]]

compare-locales needs to be run for extensions/reporter on the l10n tinderboxens
for both the trunk and the 1.8 branch, as fall out from bug 313392.

I have a change to client.mk on my disk which actually picks up the directory
settings from client.mk and using that in the tinderbox may be a better way than
to manually hack this.

Comment 1

[Chris Cooper [:coop] (he/him)]

If you've already got a working patch, that would be a great place for me to start. ;-)

Comment 2

[Axel Hecht [:Pike]]

Attachment: makefile to run locale modules comparison

It's not a patch but a different makefile including client.mk, but still.

Likely WIP.

Comment 3

[Chris Cooper [:coop] (he/him)]

Sorry, Axel, this seems to have fallen through the cracks. Is this still required?

Comment 4

[Axel Hecht [:Pike]]

I'm not sure what to do with this bug, it's still valid, though.

The makefile I attached is checked in to the tree now, http://lxr.mozilla.org/mozilla/source/tools/l10n/l10n.mk.

Comment 5

[Axel Hecht [:Pike]]

I'm running through tools/l10n/l10n.mk check-l10n on incubator now, http://l10n.mozilla.org/buildbot/. I'll probably morph running over the python version, though.

Comment 6

[Axel Hecht [:Pike]]

The buildbot version runs the python version now.

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to comment #6)
> The buildbot version runs the python version now.

Can we WONTFIX this bug or should we still try to get this in tinderbox?

Comment 8

[Axel Hecht [:Pike]]

Hard to tell, really. It's better than nothing, but there's oh so many things that the perl version doesn't grok.

On the other hand, I don't have a reviewed version of the python code either. Not that I ran the latest and greatest on the branch.

Comment 9

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Reassign back to Axel until more clearly defined.

Comment 10

[Axel Hecht [:Pike]]

All the things that go beyond this bug are in the air, and part of a discussion outside of bugzilla.

This bug is about getting tinderbox to check reporter with compare-locales.pl, and yes, we should still do that.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Turns out Firefox trunk is already doing this (via bug 402724)
 http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/tools/tinderbox-configs/firefox/win32/tinder-config.pl&rev=1.2.4.11#171

(both nightly and release configs)

Comment 12

[Axel Hecht [:Pike]]

Interesting. Should we keep this open for the branch?

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

If we did do this on the branch, would we take l10n changes for any bustage ? Are there any more locales coming on for Fx2 or are we concentrating on Fx3 now ?

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

What say you Axel ?

Comment 15

[Axel Hecht [:Pike]]

I updated my own hg trunk to the point that it's OK to run a real compare-locales on the branch. All really broken locales aren't built anymore, there are some left over strings and such that we can ignore, that's bug 435004, waiting for review from :bs. If someone wants to step in, that could only help.

If we do bug 400010, that'd be fixing it, too, as compare-locales.py automagically checks reporter.

Comment 16

[[e-mail] (:bhearsum)]

Is this still a valid bug?

Comment 17

[Axel Hecht [:Pike]]

This is fixed by using compare-locales.py on most branches, and WONTFIXed for 1.9.0.x. Resolving just FIXED for the lack of passion to find our right bugs to dupe and depend ro whatever.